Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1490713002: Revert of Convert enable_pre_sync_backup flag to new flags system. (Closed)

Created:
5 years ago by vabr (Chromium)
Modified:
5 years ago
Reviewers:
brettw, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert enable_pre_sync_backup flag to new flags system. (patchset #2 id:20001 of https://codereview.chromium.org/1487873003/ ) Reason for revert: Speculative revert, CrOS compile broken, more info on the bug. BUG=563927 Original issue's description: > Convert enable_pre_sync_backup flag to new flags system. > > This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define. > > Reland of http://crrev.com/1478623004#ps60001 > TBR=zea@chromium.org > > Committed: https://crrev.com/db7f9756dc6e236589b90c76d6fa0f1244601e78 > Cr-Commit-Position: refs/heads/master@{#362365} TBR=zea@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3c201fa28b53246177fed8d6b9454da4b0625df2 Cr-Commit-Position: refs/heads/master@{#362368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -73 lines) Patch
M build/buildflag_header.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 4 chunks +8 lines, -0 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 8 chunks +7 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 7 chunks +16 lines, -14 lines 0 comments Download
M components/browser_sync.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync_driver.gypi View 2 chunks +0 lines, -21 lines 0 comments Download
M components/sync_driver/BUILD.gn View 3 chunks +0 lines, -13 lines 0 comments Download
M components/sync_driver/backup_rollback_controller.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/sync_driver/backup_rollback_controller_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
vabr (Chromium)
Created Revert of Convert enable_pre_sync_backup flag to new flags system.
5 years ago (2015-12-01 09:31:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490713002/1
5 years ago (2015-12-01 09:34:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 09:35:35 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c201fa28b53246177fed8d6b9454da4b0625df2 Cr-Commit-Position: refs/heads/master@{#362368}
5 years ago (2015-12-01 09:36:27 UTC) #8
vabr (Chromium)
5 years ago (2015-12-01 09:45:38 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1490723002/ by vabr@chromium.org.

The reason for reverting is: Speculative revert did not help. Relanding..

Powered by Google App Engine
This is Rietveld 408576698