Support 'paint-order' from SVG2.

Source/core/css/SVGCSSParser.cpp

 /*
     Copyright (C) 2008 Eric Seidel <eric@webkit.org>
     Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
                   2004, 2005, 2007, 2010 Rob Buis <buis@kde.org>
     Copyright (C) 2005, 2006 Apple Computer, Inc.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
 
     This library is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
     Library General Public License for more details.
 
     You should have received a copy of the GNU Library General Public License
     along with this library; see the file COPYING.LIB.  If not, write to
     the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
     Boston, MA 02110-1301, USA.
 */
 
 #include "config.h"
 
 #include "CSSPropertyNames.h"
 #include "CSSValueKeywords.h"
+#include "RuntimeEnabledFeatures.h"
 #include "core/css/CSSParser.h"
 #include "core/css/CSSValueList.h"
 #include "core/rendering/RenderTheme.h"
 #include "core/svg/SVGPaint.h"
 
 using namespace std;
 
 namespace WebCore {
 
 static bool isSystemColor(int id)
@@ skipping 181 matching lines @@
         else if (id == CSSValueCurrentcolor)
             parsedValue = SVGColor::createCurrentColor();
         else // TODO : svgcolor (iccColor)
             parsedValue = parseSVGColor();
 
         if (parsedValue)
             m_valueList->next();
 
         break;
 
+    case CSSPropertyPaintOrder:
+        if (!RuntimeEnabledFeatures::svg2Enabled())
+            return false;
+
+        if (m_valueList->size() == 1 && id == CSSValueNormal)
+            valid_primitive = true;
+        else if ((parsedValue = parsePaintOrder()))
+            m_valueList->next();
+        break;
+
     case CSSPropertyVectorEffect: // none | non-scaling-stroke | inherit
         if (id == CSSValueNone || id == CSSValueNonScalingStroke)
             valid_primitive = true;
         break;
 
     case CSSPropertyWritingMode:
     // lr-tb | rl_tb | tb-rl | lr | rl | tb | inherit
         if (id == CSSValueLrTb || id == CSSValueRlTb || id == CSSValueTbRl || id == CSSValueLr || id == CSSValueRl || id == CSSValueTb)
             valid_primitive = true;
         break;
@@ skipping 123 matching lines @@
 }
 
 PassRefPtr<CSSValue> CSSParser::parseSVGColor()
 {
     RGBA32 c = Color::transparent;
     if (!parseColorFromValue(m_valueList->current(), c))
         return 0;
     return SVGColor::createFromColor(Color(c));
 }
 
+// normal | [ fill || stroke || markers ]
+PassRefPtr<CSSValue> CSSParser::parsePaintOrder() const
+{
+    if (m_valueList->size() > 3)
+        return 0;
+
+    CSSParserValue* value = m_valueList->current();
+    if (!value)
+        return 0;
+
+    RefPtr<CSSValueList> parsedValues = CSSValueList::createSpaceSeparated();
+
+    int defaultPaintOrder[] = { CSSValueFill, CSSValueStroke, CSSValueMarkers };
+    bool seen[] = { false, false, false };

[pdr., 2013/06/25 15:30:45]

Style nit (fix at your discretion)

I think this function would be cleaner with 3 bools instead of an array:
seenFill, seenStroke, and seenMarkers. This way, your for loop at the end would
turn into 3 if statements.

+    bool valid = true;
+
+    do {
+        switch (value->id) {
+        case CSSValueNormal:
+            // normal inside [fill || stroke || markers] not valid
+            return 0;
+        case CSSValueFill:
+            if (seen[0])
+                return 0;
+
+            seen[0] = true;
+            break;
+        case CSSValueStroke:
+            if (seen[1])
+                return 0;
+
+            seen[1] = true;
+            break;
+        case CSSValueMarkers:
+            if (seen[2])
+                return 0;
+
+            seen[2] = true;
+            break;
+        }
+
+        parsedValues->append(CSSPrimitiveValue::createIdentifier(value->id));
+    } while (value = m_valueList->next());
+
+    // fill out the rest of the paint order
+    for (int i = 0; i < 3; i++)

[pdr., 2013/06/25 15:30:45]

Nit: if you choose to keep this, because the body of the for loop is multi-line,
can you add braces?

+        if (!seen[i])
+            parsedValues->append(CSSPrimitiveValue::createIdentifier(defaultPaintOrder[i]));
+
+    return parsedValues;
 }
+
+}