Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: sdk/lib/_internal/compiler/implementation/elements/modelx.dart

Issue 14907008: Remove support for interface in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix constructor name bug. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/elements/modelx.dart
diff --git a/sdk/lib/_internal/compiler/implementation/elements/modelx.dart b/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
index 909c4c63f152df2363fa3cbd51e9c024077c96a4..f2fac631e10e8c4bb1dec5efdb0beb43e144f342 100644
--- a/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
+++ b/sdk/lib/_internal/compiler/implementation/elements/modelx.dart
@@ -1088,19 +1088,15 @@ class FunctionElementX extends ElementX implements FunctionElement {
* The patch should be parsed as if it was in the current scope. Its
* signature must match this function's signature.
*/
- // TODO(lrn): Consider using [defaultImplementation] to store the patch.
FunctionElement patch = null;
FunctionElement origin = null;
/**
* If this is a redirecting factory, [defaultImplementation] will be
- * changed by the resolver to point to the redirection target. If
- * this is an interface constructor, [defaultImplementation] will be
- * changed by the resolver to point to the default implementation.
+ * changed by the resolver to point to the redirection target.
* Otherwise, [:identical(defaultImplementation, this):].
*/
- // TODO(ahe): Rename this field to redirectionTarget and remove
- // mention of interface constructors above.
+ // TODO(ahe): Rename this field to redirectionTarget.
FunctionElement defaultImplementation;
FunctionElementX(SourceString name,
@@ -1360,7 +1356,6 @@ abstract class BaseClassElementX extends ElementX implements ClassElement {
*/
InterfaceType rawTypeCache;
DartType supertype;
- DartType defaultClass;
Link<DartType> interfaces;
SourceString nativeTagInfo;
int supertypeLoadState;
@@ -1491,9 +1486,6 @@ abstract class BaseClassElementX extends ElementX implements ClassElement {
if (e.modifiers.isStatic()) continue;
return e;
}
- if (isInterface()) {
- return lookupSuperInterfaceMember(memberName, getLibrary());
- }
return null;
}
@@ -1758,7 +1750,6 @@ abstract class BaseClassElementX extends ElementX implements ClassElement {
return false;
}
- bool isInterface() => false;
bool isNative() => nativeTagInfo != null;
void setNative(String name) {
nativeTagInfo = new SourceString(name);

Powered by Google App Engine
This is Rietveld 408576698