Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 1490673002: Initialize un-initialized variable that breaks wasm tests. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
titzer, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Initialize un-initialized variable that breaks wasm tests. This greens the wasm travis build. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=asm-wasm tests TBR=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/f5a0b60f8deeaf1513df336e7ca864f55578ccb3 Cr-Commit-Position: refs/heads/master@{#32448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/typing-asm.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
bradn
5 years ago (2015-12-01 05:02:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490673002/1
5 years ago (2015-12-01 05:03:07 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-01 05:03:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490673002/1
5 years ago (2015-12-01 05:08:17 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-01 05:08:18 UTC) #9
titzer
On 2015/12/01 05:08:18, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years ago (2015-12-01 10:34:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490673002/1
5 years ago (2015-12-01 10:34:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 10:52:33 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-01 10:52:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5a0b60f8deeaf1513df336e7ca864f55578ccb3
Cr-Commit-Position: refs/heads/master@{#32448}

Powered by Google App Engine
This is Rietveld 408576698