Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1490643002: Add UpdateEngine.CertificateCheck.* to histograms.xml (Closed)

Created:
5 years ago by bsimonnet
Modified:
5 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UpdateEngine.CertificateCheck.* to histograms.xml This CL adds two Chrome OS specific histograms: * UpdateEngine.CertificateCheck.Download * UpdateEngine.CertificateCheck.UpdateCheck BUG=563800 Committed: https://crrev.com/98f90bfc930621229ba9b28e7a453d603cfddc59 Cr-Commit-Position: refs/heads/master@{#363040}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bsimonnet
5 years ago (2015-12-01 01:35:30 UTC) #2
deymo
lgtm w/nit. You will need OWNER review. +rkaplow for that. https://codereview.chromium.org/1490643002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1490643002/diff/1/tools/metrics/histograms/histograms.xml#newcode45240 ...
5 years ago (2015-12-01 18:15:16 UTC) #4
bsimonnet
On 2015/12/01 18:15:16, deymo wrote: > lgtm w/nit. > > You will need OWNER review. ...
5 years ago (2015-12-01 18:58:07 UTC) #5
bsimonnet
5 years ago (2015-12-02 20:45:53 UTC) #7
rkaplow
lgtm oops, sorry for delay
5 years ago (2015-12-03 15:41:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490643002/20001
5 years ago (2015-12-03 17:59:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 20:08:42 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-03 20:10:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98f90bfc930621229ba9b28e7a453d603cfddc59
Cr-Commit-Position: refs/heads/master@{#363040}

Powered by Google App Engine
This is Rietveld 408576698