Issue 149063009: Make the Convolver unit tests run in sane amount of time in DEBUG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149063009: Make the Convolver unit tests run in sane amount of time in DEBUG. (Closed)

Created:
6 years, 10 months ago by Stephen White

Modified:
6 years, 10 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make the Convolver unit tests run in a sane amout of time in DEBUG. Since we are only testing correctness and not performance in Debug, we can use much smaller images and still get decent coverage. This reduces the runtime in Debug from 17092ms to 191ms. BUG=338133 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247858

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	skia/ext/convolver_unittest.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/149063009/1

6 years, 10 months ago (2014-01-29 22:59:49 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253925

6 years, 10 months ago (2014-01-30 02:08:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/149063009/1

6 years, 10 months ago (2014-01-30 03:19:35 UTC) #5

Message was sent while issue was closed.

Change committed as 247858

Expand Messages | Collapse Messages