Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 149063009: Make the Convolver unit tests run in sane amount of time in DEBUG. (Closed)

Created:
6 years, 10 months ago by Stephen White
Modified:
6 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Make the Convolver unit tests run in a sane amout of time in DEBUG. Since we are only testing correctness and not performance in Debug, we can use much smaller images and still get decent coverage. This reduces the runtime in Debug from 17092ms to 191ms. BUG=338133 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M skia/ext/convolver_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
cpu: PTAL. Thanks!
6 years, 10 months ago (2014-01-29 21:11:26 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 10 months ago (2014-01-29 22:14:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/149063009/1
6 years, 10 months ago (2014-01-29 22:59:49 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253925
6 years, 10 months ago (2014-01-30 02:08:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/149063009/1
6 years, 10 months ago (2014-01-30 03:19:35 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:47:06 UTC) #6
Message was sent while issue was closed.
Change committed as 247858

Powered by Google App Engine
This is Rietveld 408576698