Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1490623002: Fix rolling averages in diagnostic status. (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix rolling averages in diagnostic status. * updates sampler to return `num`s * migrates status get_handler to one shared handler for diagnostics R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/c84ea322ffe9cdfd1886e315ff483928acce09b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-12-01 00:57:06 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-12-01 03:28:11 UTC) #3
pquitslund
5 years ago (2015-12-01 05:24:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c84ea322ffe9cdfd1886e315ff483928acce09b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698