media config: expand is_encrypted to a struct.

media/formats/webm/webm_audio_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/formats/webm/webm_audio_client.h"
 
 #include "media/base/audio_decoder_config.h"
 #include "media/base/channel_layout.h"
+#include "media/base/encryption_scheme.h"
 #include "media/formats/webm/webm_constants.h"
 
 namespace media {
 
 WebMAudioClient::WebMAudioClient(const scoped_refptr<MediaLog>& media_log)
     : media_log_(media_log) {
   Reset();
 }
 
 WebMAudioClient::~WebMAudioClient() {
@@ skipping 49 matching lines @@
 
   // Convert |codec_delay| from nanoseconds into frames.
   int codec_delay_in_frames = 0;
   if (codec_delay != -1) {
     codec_delay_in_frames =
         0.5 +
         samples_per_second * (static_cast<double>(codec_delay) /
                               base::Time::kNanosecondsPerSecond);
   }
 
-  config->Initialize(
-      audio_codec,
-      sample_format,
-      channel_layout,
-      samples_per_second,
-      codec_private,
-      is_encrypted,
-      base::TimeDelta::FromMicroseconds(
-          (seek_preroll != -1 ? seek_preroll : 0) / 1000),
-      codec_delay_in_frames);
+  config->Initialize(audio_codec, sample_format, channel_layout,
+                     samples_per_second, codec_private,
+                     EncryptionScheme(is_encrypted),

[ddorwin, 2015/12/10 18:36:02]

Even here, it might make sense to explicitly say AES-CTR no pattern because that
is now WebM is specified.

[dougsteed, 2015/12/14 21:19:02]

I wasn't aware that WebM was like that. But even so, wouldn't it make sense to
do that later when/if WebM adds other options? For now, the default has been set
up to be backwards compatible.

[ddorwin, 2016/03/01 02:17:41]

I'd rather be explicit than rely on a default, especially since it won't be
clear from reading the actual code that deals with the containers.

By specifying it now, we are being clear about what the spec says now. I don't
think whether there are options is relevant to this.

[dougsteed, 2016/03/02 18:07:52]

Done.

+                     base::TimeDelta::FromMicroseconds(
+                         (seek_preroll != -1 ? seek_preroll : 0) / 1000),
+                     codec_delay_in_frames);
   return config->IsValidConfig();
 }
 
 bool WebMAudioClient::OnUInt(int id, int64 val) {
   if (id == kWebMIdChannels) {
     if (channels_ != -1) {
       MEDIA_LOG(ERROR, media_log_) << "Multiple values for id " << std::hex
                                    << id << " specified. (" << channels_
                                    << " and " << val << ")";
       return false;
@@ skipping 26 matching lines @@
                                  << " specified (" << *dst << " and " << val
                                  << ")";
     return false;
   }
 
   *dst = val;
   return true;
 }
 
 }  // namespace media