media config: expand is_encrypted to a struct.

chromecast/media/audio/cast_audio_output_stream_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/synchronization/waitable_event.h"
 #include "chromecast/base/metrics/cast_metrics_test_helper.h"
 #include "chromecast/media/audio/cast_audio_manager.h"
 #include "chromecast/media/audio/cast_audio_output_stream.h"
 #include "chromecast/media/base/media_message_loop.h"
@@ skipping 363 matching lines @@
     format_ = format[i];
     ::media::AudioOutputStream* stream = CreateStream();
     ASSERT_TRUE(stream);
     EXPECT_TRUE(OpenStream(stream));
 
     FakeAudioDecoder* audio_decoder = GetAudio();
     ASSERT_TRUE(audio_decoder);
     const AudioConfig& audio_config = audio_decoder->config();
     EXPECT_EQ(kCodecPCM, audio_config.codec);
     EXPECT_EQ(kSampleFormatS16, audio_config.sample_format);
-    EXPECT_FALSE(audio_config.is_encrypted);
+    EXPECT_FALSE(audio_config.encryption_scheme.is_encrypted);

[ddorwin, 2015/12/10 18:36:00]

Do we not have any similar tests for non-Chromecast code? Or perhaps those are
hidden by is_encrypted() calls. Please find and update any such tests.

[ddorwin, 2015/12/10 18:36:00]

Are there other members we can/should test?

[dougsteed, 2015/12/14 21:19:01]

Pretty sure I updated all the tests, as it would not compile otherwise.

[dougsteed, 2015/12/14 21:19:01]

Do you mean members of audio_config, or of audio_config.encryption_scheme ? In
any case, I am not familiar with the nuances of these tests, so all I am doing
is trying to preserve the semantics of the existing test.

[ddorwin, 2016/03/01 02:17:40]

I was referring to EncryptionScheme. The values should be whatever the defaults
are (no encryption) or the values for CENC v1.

[ddorwin, 2016/03/01 02:17:41]

This comment doesn't actually apply here. I moved it to audio_decoder_config.h.

 
     CloseStream(stream);
   }
 }
 
 TEST_F(CastAudioOutputStreamTest, ChannelLayout) {
   ::media::ChannelLayout layout[] = {::media::CHANNEL_LAYOUT_MONO,
                                      ::media::CHANNEL_LAYOUT_STEREO};
   for (size_t i = 0; i < arraysize(layout); ++i) {
     channel_layout_ = layout[i];
@@ skipping 248 matching lines @@
 TEST_F(CastAudioOutputStreamTest, CloseWithoutStart) {
   ::media::AudioOutputStream* stream = CreateStream();
   ASSERT_TRUE(stream);
   ASSERT_TRUE(OpenStream(stream));
   CloseStream(stream);
 }
 
 }  // namespace
 }  // namespace media
 }  // namespace chromecast