Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1490593002: Passing zone to type objects so printing macros work in arm debug mode. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
titzer, bbudge
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Passing zone to type objects so printing macros work in arm debug mode. The Type::Print method requires an explict zone, even for basic types on arm debug. This change introduced debug mode printing when types don't match: https://codereview.chromium.org/1471073003/ Adding the zone parameter to make the arm build go green. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=local arm build TBR=bbudge@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/a63023206f5ee59cc7bb883bf08bd591991b8ee3 Cr-Commit-Position: refs/heads/master@{#32424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M test/cctest/test-asm-validator.cc View 10 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bradn
5 years ago (2015-11-30 22:28:06 UTC) #1
bbudge
lgtm
5 years ago (2015-11-30 22:29:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490593002/1
5 years ago (2015-11-30 22:32:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8296)
5 years ago (2015-11-30 22:35:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490593002/1
5 years ago (2015-11-30 22:42:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 22:48:00 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-30 22:49:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a63023206f5ee59cc7bb883bf08bd591991b8ee3
Cr-Commit-Position: refs/heads/master@{#32424}

Powered by Google App Engine
This is Rietveld 408576698