Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1490553002: PPC: [compiler] Always pass closure argument to with, catch and block context creation. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch07
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [compiler] Always pass closure argument to with, catch and block context creation. Port d3e5db04287b0b853e28552119e4177eb3bf10b9 Original commit message: Up until now we sometimes pass Smi 0 around as closure and expect the runtime to translate that appropriately. But we need to be careful in some places to not confuse the Smi 0 with a real closure. However, we could instead just pass the correct closure extracted from the native context. This addresses three long-standing TODOs in the JSTypedLowering pass. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/219794daabf030063f02163010ab34b2d1469633 Cr-Commit-Position: refs/heads/master@{#32430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
MTBrandyberry
5 years ago (2015-11-30 21:00:07 UTC) #1
MTBrandyberry
5 years ago (2015-11-30 21:00:14 UTC) #2
michael_dawson
On 2015/11/30 21:00:14, mtbrandyberry wrote: lgtm
5 years ago (2015-11-30 21:28:48 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1490513004 Patch 1). Please resolve the dependency and ...
5 years ago (2015-11-30 21:29:18 UTC) #6
john.yan
lgtm
5 years ago (2015-11-30 22:54:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490553002/1
5 years ago (2015-12-01 01:28:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 02:11:14 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-01 02:11:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/219794daabf030063f02163010ab34b2d1469633
Cr-Commit-Position: refs/heads/master@{#32430}

Powered by Google App Engine
This is Rietveld 408576698