Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 149053006: cc: Add TRACE_EVENTs to SingleThreadProxy (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, aelias_OOO_until_Jul13, clholgat, epenner
Visibility:
Public.

Description

cc: Add TRACE_EVENTs to SingleThreadProxy This adds traces to entry points in SingleThreadProxy that have analogous trace events in the ThreadProxy. Also add trace points along the critical CompositeImmediately -> CommitAndComposite -> DoCommit/DoComposite code path. R=enne BUG=339248 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247874

Patch Set 1 #

Total comments: 2

Patch Set 2 : traces: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M cc/trees/single_thread_proxy.cc View 1 10 chunks +16 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 9 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
6 years, 10 months ago (2014-01-29 23:22:17 UTC) #1
enne (OOO)
lgtm https://codereview.chromium.org/149053006/diff/1/cc/trees/single_thread_proxy.cc File cc/trees/single_thread_proxy.cc (right): https://codereview.chromium.org/149053006/diff/1/cc/trees/single_thread_proxy.cc#newcode86 cc/trees/single_thread_proxy.cc:86: TRACE_EVENT0("cc", "SingleThreadProxy::FinishAllRendering"); nit: put this trace before the ...
6 years, 10 months ago (2014-01-30 00:03:18 UTC) #2
danakj
https://codereview.chromium.org/149053006/diff/1/cc/trees/single_thread_proxy.cc File cc/trees/single_thread_proxy.cc (right): https://codereview.chromium.org/149053006/diff/1/cc/trees/single_thread_proxy.cc#newcode86 cc/trees/single_thread_proxy.cc:86: TRACE_EVENT0("cc", "SingleThreadProxy::FinishAllRendering"); On 2014/01/30 00:03:18, enne wrote: > nit: ...
6 years, 10 months ago (2014-01-30 00:06:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/149053006/20001
6 years, 10 months ago (2014-01-30 00:12:29 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 03:04:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/149053006/20001
6 years, 10 months ago (2014-01-30 03:12:45 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 07:33:33 UTC) #7
Message was sent while issue was closed.
Change committed as 247874

Powered by Google App Engine
This is Rietveld 408576698