public/DEPS - Issue 149053002: Blink WebTouchPoint stores its location as WebFloatPoint, instead of WebPoint.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/DEPS

Issue 149053002: Blink WebTouchPoint stores its location as WebFloatPoint, instead of WebPoint. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Rebase / minor fixes. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+wtf",	2 "+wtf",

	3 "+../platform"
	jamesr 2014/02/03 21:48:23 don't do this don't do this tdresser 2014/02/04 14:46:23 I had a conversation with joi@ about the correct a Show quoted text On 2014/02/03 21:48:23, jamesr wrote: > don't do this I had a conversation with joi@ about the correct approach here, and this is what he recommended (though he did suggest I could make the rule more specific.) Because this needs to work in both the blink and chromium builds, using an absolute path doesn't work. I agree this seems like a bad plan (there are only 2 other occurrences of using .. in a DEPS file in blink), but I'm not sure what the correct approach is. Any ideas? Jói 2014/02/04 15:10:15 Yeah, checkdeps works on the include paths as they Show quoted text On 2014/02/04 14:46:23, tdresser wrote: > On 2014/02/03 21:48:23, jamesr wrote: > > don't do this > > I had a conversation with joi@ about the correct approach here, and this is what > he recommended (though he did suggest I could make the rule more specific.) > > Because this needs to work in both the blink and chromium builds, using an > absolute path doesn't work. > > I agree this seems like a bad plan (there are only 2 other occurrences of using > .. in a DEPS file in blink), but I'm not sure what the correct approach is. Any > ideas? Yeah, checkdeps works on the include paths as they are actually written, so this is the only approach that will currently work, as far as I know, except perhaps to change the include paths for the projects in question so that they can both include this header via the same directory. That is probably a worse solution and would still leave us with a non-standard include rule in this DEPS file. There should be a comment explaining why .. is used, though.
3 ]	4 ]

OLD	NEW