LayoutTests/fast/events/touch/touch-coords-rounded.html - Issue 149053002: Blink WebTouchPoint stores its location as WebFloatPoint, instead of WebPoint.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/touch-coords-rounded.html

Issue 149053002: Blink WebTouchPoint stores its location as WebFloatPoint, instead of WebPoint. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Rebase / minor fixes. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
	jamesr 2014/02/03 21:48:23 say <!DOCTYPE html> if you want to define a modern say <!DOCTYPE html> if you want to define a modern HTML document. only use other strings if you are specifically testing a legacy document type tdresser 2014/02/04 14:46:23 Done. Show quoted text On 2014/02/03 21:48:23, jamesr wrote: > say <!DOCTYPE html> if you want to define a modern HTML document. only use other > strings if you are specifically testing a legacy document type Done.
	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body onload="test()">

	7 <p> This test ensures that touch events with floating point locations

	8 have their locations floored before they are passed to javascript.</p>
	jamesr 2014/02/03 21:48:23 if we specify these values as type 'long' in the W if we specify these values as type 'long' in the WebIDL, shouldn't the flooring happen in that bindings layer and not in our C++ code? tdresser 2014/02/04 14:46:23 That's what's happening, isn't it? I guess I've wo Show quoted text On 2014/02/03 21:48:23, jamesr wrote: > if we specify these values as type 'long' in the WebIDL, shouldn't the flooring > happen in that bindings layer and not in our C++ code? That's what's happening, isn't it? I guess I've worded this badly, it should say "as they are passed to javascript". (DONE) I think it's worth a test to ensure the truncation behaves as we expect it to.
	9 <div id="result">FAIL</div>

	10 <script>

	11 function test()

	12 {

	13 var x = 10.3;

	14 var y = 10.7;

	15

	16 if (window.testRunner)

	17 testRunner.dumpAsText();

	18

	19 document.addEventListener('touchstart', function(e) {

	20 if (e.changedTouches[0].screenX === 10 &&

	21 e.changedTouches[0].screenY === 10) {

	22 document.getElementById("result").innerHTML = "PASS";

	23 }

	24 });

	25

	26 if (window.eventSender) {

	27 eventSender.clearTouchPoints();

	28 eventSender.addTouchPoint(x, y);

	29 eventSender.touchStart();

	30 }

	31 }

	32 </script>

	33 </body>

	34 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/touch/touch-coords-rounded-expected.txt » ('j') | public/DEPS » ('J')