Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1490513005: Add support for ManagedMemoryPolicy (de)serialization (Closed)

Created:
5 years ago by nyquist
Modified:
5 years ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@renderer-settings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for ManagedMemoryPolicy (de)serialization As part of serializing cc::LayerTreeHost, we also need to serialize the cc::LayerTreeSettings and the cc::ManagedMemoryPolicy. This CL focuses on the cc::ManagedMemoryPolicy and the gpu::MemoryAllocation::PriorityCutoff enum. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/1d29b060b31f3e4c2d86c818188b8c608e1ac34d Cr-Commit-Position: refs/heads/master@{#362603}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Add missing return-statements for conversions #

Total comments: 6

Patch Set 4 : Addressed comments #

Total comments: 1

Patch Set 5 : Changed DLOG(FATAL) to NOTREACHED() #

Patch Set 6 : Rebase on top of origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -18 lines) Patch
M cc/BUILD.gn View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M cc/output/managed_memory_policy.h View 2 chunks +7 lines, -0 lines 0 comments Download
M cc/output/managed_memory_policy.cc View 2 chunks +17 lines, -0 lines 0 comments Download
A cc/output/managed_memory_policy_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M cc/proto/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A cc/proto/gpu_conversions.h View 1 chunk +25 lines, -0 lines 0 comments Download
A cc/proto/gpu_conversions.cc View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A cc/proto/gpu_conversions_unittest.cc View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A + cc/proto/managed_memory_policy.proto View 1 chunk +7 lines, -7 lines 0 comments Download
A + cc/proto/memory_allocation.proto View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 29 (13 generated)
nyquist
vmpstr: PTAL
5 years ago (2015-11-30 22:49:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490513005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490513005/20001
5 years ago (2015-11-30 22:53:11 UTC) #5
nyquist
dtrainor: PTAL
5 years ago (2015-11-30 22:58:04 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/164133) chromeos_amd64-generic_chromium_compile_only_ng on ...
5 years ago (2015-11-30 23:23:26 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490513005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490513005/40001
5 years ago (2015-12-01 00:46:09 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 02:41:17 UTC) #13
David Trainor- moved to gerrit
lgtm
5 years ago (2015-12-01 07:18:31 UTC) #14
vmpstr
https://codereview.chromium.org/1490513005/diff/40001/cc/cc_tests.gyp File cc/cc_tests.gyp (right): https://codereview.chromium.org/1490513005/diff/40001/cc/cc_tests.gyp#newcode77 cc/cc_tests.gyp:77: 'output/managed_memory_policy_unittest', .cc https://codereview.chromium.org/1490513005/diff/40001/cc/proto/gpu_conversions_unittest.cc File cc/proto/gpu_conversions_unittest.cc (right): https://codereview.chromium.org/1490513005/diff/40001/cc/proto/gpu_conversions_unittest.cc#newcode17 cc/proto/gpu_conversions_unittest.cc:17: i++) ...
5 years ago (2015-12-01 18:59:53 UTC) #15
nyquist
vmpstr: PTAL https://codereview.chromium.org/1490513005/diff/40001/cc/cc_tests.gyp File cc/cc_tests.gyp (right): https://codereview.chromium.org/1490513005/diff/40001/cc/cc_tests.gyp#newcode77 cc/cc_tests.gyp:77: 'output/managed_memory_policy_unittest', On 2015/12/01 18:59:52, vmpstr wrote: > ...
5 years ago (2015-12-01 22:36:47 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490513005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490513005/60001
5 years ago (2015-12-02 00:24:50 UTC) #18
vmpstr
lgtm https://codereview.chromium.org/1490513005/diff/60001/cc/proto/gpu_conversions.cc File cc/proto/gpu_conversions.cc (right): https://codereview.chromium.org/1490513005/diff/60001/cc/proto/gpu_conversions.cc#newcode40 cc/proto/gpu_conversions.cc:40: DLOG(FATAL) << "Received MemoryAllocation::PriorityCutoff_UNKNOWN"; You just put NOTREACHED() ...
5 years ago (2015-12-02 00:25:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490513005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490513005/100001
5 years ago (2015-12-02 00:47:26 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/148429)
5 years ago (2015-12-02 00:55:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490513005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490513005/100001
5 years ago (2015-12-02 02:07:59 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-02 02:48:27 UTC) #27
commit-bot: I haz the power
5 years ago (2015-12-02 02:49:06 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1d29b060b31f3e4c2d86c818188b8c608e1ac34d
Cr-Commit-Position: refs/heads/master@{#362603}

Powered by Google App Engine
This is Rietveld 408576698