MD Settings: Adding unit test for ResetSettingsHandler.

chrome/browser/ui/webui/settings/reset_settings_handler_unittest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/values.h"
+#include "chrome/browser/profile_resetter/profile_resetter.h"
+#include "chrome/browser/ui/webui/settings/reset_settings_handler.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/web_ui_data_source.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "content/public/test/test_web_ui.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using settings::ResetSettingsHandler;
+
+namespace {
+
+// Mock version of ProfileResetter to be used in tests.
+class MockProfileResetter : public ProfileResetter {
+ public:
+  explicit MockProfileResetter(TestingProfile* profile)
+      : ProfileResetter(profile) {
+  }
+
+  bool IsActive() const override {
+    return false;
+  }
+
+  void Reset(ResettableFlags resettable_flags,
+             scoped_ptr<BrandcodedDefaultSettings> master_settings,
+             const base::Closure& callback) override {
+    resets_++;
+    callback.Run();
+  }
+
+  size_t resets() const {
+    return resets_;
+  }
+
+ private:
+  size_t resets_ = 0;
+};
+
+
+class TestingResetSettingsHandler : public ResetSettingsHandler {
+ public:
+  TestingResetSettingsHandler(
+      TestingProfile* profile, bool allow_powerwash, content::WebUI* web_ui)
+      : ResetSettingsHandler(profile, allow_powerwash),
+        resetter_(profile) {
+    set_web_ui(web_ui);
+  }
+
+  size_t resets() const { return resetter_.resets(); }
+
+  using settings::ResetSettingsHandler::HandleResetProfileSettings;
+
+ protected:
+  MockProfileResetter* GetResetter() override {

[Dan Beam, 2015/12/02 20:08:36]

ProfileResetter or find precedence for doing this in Chrome

[dpapad, 2015/12/02 21:33:35]

Done. Changed to ProfileResetter. MockProfileResetter* was needed when I was
calling

handler()->GetResetter()->resets();
from the test. Now that we wrapped it with
handler()->resets();
it does not need to retur MockProfileResetter*.

[Dan Beam, 2015/12/02 21:36:15]

i know :), which is part of why I suggested that

+    return &resetter_;
+  }
+
+private:
+  MockProfileResetter resetter_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestingResetSettingsHandler);
+};
+
+
+// The fixture for testing class Foo.

[Dan Beam, 2015/12/02 21:36:52]

lol whoops

[dpapad, 2015/12/02 21:41:05]

Already removed in latest patch (#6).

+class ResetSettingsHandlerTest : public testing::Test {
+ public:
+  ResetSettingsHandlerTest() : handler_(&profile_, false, &web_ui_) {
+  }
+
+  TestingResetSettingsHandler* handler() {
+    return &handler_;
+  }
+
+  content::TestWebUI* web_ui() {
+    return &web_ui_;
+  }
+
+ private:
+  // The order here matters.
+  content::TestBrowserThreadBundle thread_bundle_;
+  TestingProfile profile_;
+  content::TestWebUI web_ui_;
+  TestingResetSettingsHandler handler_;
+};
+
+TEST_F(ResetSettingsHandlerTest, HandleResetProfileSettings) {
+  base::ListValue list;
+  list.AppendBoolean(false);
+  handler()->HandleResetProfileSettings(&list);
+  // Check that the delegate ProfileResetter was called.
+  EXPECT_EQ((size_t)1, handler()->resets());

[Dan Beam, 2015/12/02 20:08:36]

1u

[dpapad, 2015/12/02 21:33:35]

Done.

+  // Check that Javascript side is notified after resetting is done.
+  EXPECT_EQ("SettingsResetPage.doneResetting",
+            web_ui()->call_data()[0]->function_name());
+}
+
+}  // namespace