MD Settings: Adding unit test for ResetSettingsHandler.

chrome/browser/ui/webui/settings/reset_settings_handler.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/ui/webui/settings/md_settings_ui.h"
 
 namespace base {
 class DictionaryValue;
 class ListValue;
 }  // namespace base
 
 namespace content {
 class WebUIDataSource;
 }
 
 class BrandcodeConfigFetcher;
+class Profile;
 class ProfileResetter;
 class ResettableSettingsSnapshot;
 
 namespace settings {
 
 // Handler for
 //  1) 'Reset Profile Settings' dialog
 //  2) 'Powerwash' dialog (ChromeOS only)
 class ResetSettingsHandler
     : public SettingsPageUIHandler,
       public base::SupportsWeakPtr<ResetSettingsHandler> {
  public:
-  explicit ResetSettingsHandler(
-      content::WebUIDataSource* html_source, content::WebUI* web_ui);
   ~ResetSettingsHandler() override;
 
+  static ResetSettingsHandler* Create(
+      content::WebUIDataSource* html_source, Profile* profile);
+
   // WebUIMessageHandler implementation.
   void RegisterMessages() override;
 
- private:
+ protected:
+  ResetSettingsHandler(Profile* profile, bool allow_powerwash);
+
+  // Overriden in tests to substitute with a test version of ProfileResetter.
+  virtual ProfileResetter* GetResetter();
+
   // Javascript callback to start clearing data.
   void HandleResetProfileSettings(const base::ListValue* value);
 
-  // Closes the dialog once all requested settings has been reset.
-  void OnResetProfileSettingsDone(bool send_feedback);
-
+ private:
   // Called when the confirmation box appears.
   void OnShowResetProfileDialog(const base::ListValue* value);
 
   // Called when the confirmation box disappears.
   void OnHideResetProfileDialog(const base::ListValue* value);
 
+  // Closes the dialog once all requested settings has been reset.
+  void OnResetProfileSettingsDone(bool send_feedback);

[Dan Beam, 2015/12/02 04:40:07]

nit: revert moving of this method to maintain the blame

[dpapad, 2015/12/02 19:55:22]

Done.

+
   // Called when BrandcodeConfigFetcher completed fetching settings.
   void OnSettingsFetched();
 
   // Resets profile settings to default values. |send_settings| is true if user
   // gave his consent to upload broken settings to Google for analysis.
   void ResetProfile(bool send_settings);
 
   // Sets new values for the feedback area.
   void UpdateFeedbackUI();
 
 #if defined(OS_CHROMEOS)
   // Will be called when powerwash dialog is shown.
   void OnShowPowerwashDialog(const base::ListValue* args);
 
   // Sets a pref indicating that a factory reset is requested and then requests
   // a restart.
   void HandleFactoryResetRestart(const base::ListValue* args);
 
   // Whether factory reset can be performed.
   bool allow_powerwash_ = false;
 #endif  // defined(OS_CHROMEOS)
 
+  Profile* profile_;

[Dan Beam, 2015/12/02 04:40:08]

nit: Profile* const profile_;

[dpapad, 2015/12/02 19:55:22]

Done.

+
   scoped_ptr<ProfileResetter> resetter_;
 
   scoped_ptr<BrandcodeConfigFetcher> config_fetcher_;
 
   // Snapshot of settings before profile was reseted.
   scoped_ptr<ResettableSettingsSnapshot> setting_snapshot_;
 
   // Contains Chrome brand code; empty for organic Chrome.
   std::string brandcode_;
 
   DISALLOW_COPY_AND_ASSIGN(ResetSettingsHandler);
 };
 
 }  // namespace settings
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SETTINGS_RESET_SETTINGS_HANDLER_H_