Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 1490493003: Revert of Exclude failing test on drmemory bots

Created:
5 years ago by zhaoqin
Modified:
5 years ago
Reviewers:
asanka, oshima, zhaoqin1
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Exclude failing test on drmemory bots (patchset #1 id:1 of https://codereview.chromium.org/613853002/ ) Reason for revert: The issue has been fixed in Dr. Memory and updated to Chromium Original issue's description: > Exclude failing test on drmemory bots > > BUG=418748 > TBR=asanka@chromium.org, > > Committed: https://crrev.com/83deae695a4f415c52723850353e81b6b98d4b15 > Cr-Commit-Position: refs/heads/master@{#297278} TBR=asanka@chromium.org,oshima@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=418748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zhaoqin
Created Revert of Exclude failing test on drmemory bots
5 years ago (2015-12-01 17:00:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490493003/1
5 years ago (2015-12-01 17:03:23 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-01 17:03:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490493003/1
5 years ago (2015-12-01 17:05:10 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-01 17:05:11 UTC) #8
oshima
lgtm
5 years ago (2015-12-01 17:39:58 UTC) #9
asanka
5 years ago (2015-12-01 17:52:09 UTC) #10
lgtm

Powered by Google App Engine
This is Rietveld 408576698