Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1490473004: Roll CQ client changes 7d916d5..f59ed9f (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll CQ client changes 7d916d5..f59ed9f BUG=chromium:561530 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297753

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename #

Patch Set 3 : Rename #

Patch Set 4 : Rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -45 lines) Patch
M third_party/cq_client/cq.proto View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/cq_client/cq.pb.go View 14 chunks +93 lines, -25 lines 0 comments Download
M third_party/cq_client/cq_pb2.py View 1 8 chunks +13 lines, -13 lines 0 comments Download
M third_party/cq_client/test/cq_gerrit.cfg View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/cq_client/test/cq_rietveld.cfg View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL are the protobuf changes correct like this? I just copied over the current files ...
5 years ago (2015-12-01 10:25:23 UTC) #3
Sergiy Byelozyorov
https://codereview.chromium.org/1490473004/diff/1/third_party/cq_client/cq_pb2.py File third_party/cq_client/cq_pb2.py (left): https://codereview.chromium.org/1490473004/diff/1/third_party/cq_client/cq_pb2.py#oldcode6 third_party/cq_client/cq_pb2.py:6: # back. More details on why we chose to ...
5 years ago (2015-12-01 10:27:55 UTC) #4
Michael Achenbach
Done. PTAL
5 years ago (2015-12-01 10:39:46 UTC) #5
Sergiy Byelozyorov
lgtm
5 years ago (2015-12-01 10:41:22 UTC) #6
Sergiy Byelozyorov
lgtm lgtm
5 years ago (2015-12-01 10:41:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490473004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490473004/60001
5 years ago (2015-12-01 10:41:53 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-01 10:43:39 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297753

Powered by Google App Engine
This is Rietveld 408576698