Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1490413002: PPC: [debugger] simplify reloc info for debug break slots. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [debugger] simplify reloc info for debug break slots. Port 531dde9f80cb4e6aaa03083b42285c319a47867f Original commit message: The new step-in implementation no longer tries to predict the step-in target, so we don't need the arguments count nor call type anymore. R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/74d92ca83c802f3874d39fddef92660fbd9560e9 Cr-Commit-Position: refs/heads/master@{#32533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/debug/ppc/debug-ppc.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
MTBrandyberry
5 years ago (2015-12-02 19:23:52 UTC) #1
michael_dawson
On 2015/12/02 19:23:52, mtbrandyberry wrote: lgtm
5 years ago (2015-12-02 21:09:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490413002/1
5 years ago (2015-12-02 21:12:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490413002/1
5 years ago (2015-12-02 22:22:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 22:39:45 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-02 22:41:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74d92ca83c802f3874d39fddef92660fbd9560e9
Cr-Commit-Position: refs/heads/master@{#32533}

Powered by Google App Engine
This is Rietveld 408576698