Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl

Issue 1490403003: MediaRecorder IDL nits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
index 2b92f95e497e1899a165223dba9f89df298e5c6e..3d5af675c1d5eede3e33e2d22cd20239654c942d 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
@@ -11,13 +11,13 @@ enum RecordingStateEnum { "inactive", "recording", "paused" };
ActiveDOMObject,
// TODO(mcasas): consider changing |mimeType| to a dictionary with said key, see https://github.com/w3c/mediacapture-record/issues/19
// TODO(mcasas): Remove [TreatUndefinedAs], see https://github.com/w3c/mediacapture-record/issues/7
- Constructor(MediaStream stream, [TreatUndefinedAs=Missing] optional DOMString mimeType),
+ Constructor(MediaStream stream, optional MediaRecorderOptions options),
ConstructorCallWith=ExecutionContext,
RaisesException=Constructor,
RuntimeEnabled=MediaRecorder,
] interface MediaRecorder : EventTarget {
readonly attribute MediaStream stream;
- readonly attribute DOMString mimeType;
+ readonly attribute DOMString mimeType; // 'type' should would be nice if Gecko agrees to change it
readonly attribute RecordingStateEnum state;
attribute boolean ignoreMutedMedia;
@@ -34,5 +34,5 @@ enum RecordingStateEnum { "inactive", "recording", "paused" };
[RaisesException] void resume();
[RaisesException] void requestData();
- static DOMString canRecordMimeType(DOMString mimeType);
+ static boolean isTypeSupported(DOMString type);
};

Powered by Google App Engine
This is Rietveld 408576698