src/ia32/lithium-ia32.cc - Issue 14904008: Robustification: Always assign an environment to LModI when a deopt is possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-ia32.cc

Issue 14904008: Robustification: Always assign an environment to LModI when a deopt is possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-ia32.cc

diff --git a/src/ia32/lithium-ia32.cc b/src/ia32/lithium-ia32.cc

index d57a242513885e9bb3b0a78f61698248b815a0a9..45261e3fc783dd074efad946ebcb2e445a85b178 100644

--- a/src/ia32/lithium-ia32.cc

+++ b/src/ia32/lithium-ia32.cc

@@ -1538,7 +1538,8 @@ LInstruction* LChunkBuilder::DoMod(HMod* instr) {

}

return (instr->CheckFlag(HValue::kBailoutOnMinusZero) ||

- instr->CheckFlag(HValue::kCanBeDivByZero))

+ instr->CheckFlag(HValue::kCanBeDivByZero) ||

+ instr->CheckFlag(HValue::kCanOverflow))

? AssignEnvironment(result)

: result;

} else if (instr->representation().IsTagged()) {

« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »