Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 14904008: Robustification: Always assign an environment to LModI when a deopt is possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1359 matching lines...) Expand 10 before | Expand all | Expand 10 after
1370 LOperand* dividend = UseRegister(instr->left()); 1370 LOperand* dividend = UseRegister(instr->left());
1371 LOperand* divisor = UseRegister(instr->right()); 1371 LOperand* divisor = UseRegister(instr->right());
1372 mod = new(zone()) LModI(dividend, 1372 mod = new(zone()) LModI(dividend,
1373 divisor, 1373 divisor,
1374 TempRegister(), 1374 TempRegister(),
1375 FixedTemp(f20), 1375 FixedTemp(f20),
1376 FixedTemp(f22)); 1376 FixedTemp(f22));
1377 } 1377 }
1378 1378
1379 if (instr->CheckFlag(HValue::kBailoutOnMinusZero) || 1379 if (instr->CheckFlag(HValue::kBailoutOnMinusZero) ||
1380 instr->CheckFlag(HValue::kCanBeDivByZero)) { 1380 instr->CheckFlag(HValue::kCanBeDivByZero) ||
1381 instr->CheckFlag(HValue::kCanOverflow)) {
1381 return AssignEnvironment(DefineAsRegister(mod)); 1382 return AssignEnvironment(DefineAsRegister(mod));
1382 } else { 1383 } else {
1383 return DefineAsRegister(mod); 1384 return DefineAsRegister(mod);
1384 } 1385 }
1385 } else if (instr->representation().IsTagged()) { 1386 } else if (instr->representation().IsTagged()) {
1386 return DoArithmeticT(Token::MOD, instr); 1387 return DoArithmeticT(Token::MOD, instr);
1387 } else { 1388 } else {
1388 ASSERT(instr->representation().IsDouble()); 1389 ASSERT(instr->representation().IsDouble());
1389 // We call a C function for double modulo. It can't trigger a GC. 1390 // We call a C function for double modulo. It can't trigger a GC.
1390 // We need to use fixed result register for the call. 1391 // We need to use fixed result register for the call.
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2491 2492
2492 2493
2493 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2494 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2494 LOperand* object = UseRegister(instr->object()); 2495 LOperand* object = UseRegister(instr->object());
2495 LOperand* index = UseRegister(instr->index()); 2496 LOperand* index = UseRegister(instr->index());
2496 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2497 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2497 } 2498 }
2498 2499
2499 2500
2500 } } // namespace v8::internal 2501 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698