Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 14904008: Robustification: Always assign an environment to LModI when a deopt is possible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1441 matching lines...) Expand 10 before | Expand all | Expand 10 after
1452 LOperand* dividend = UseRegister(instr->left()); 1452 LOperand* dividend = UseRegister(instr->left());
1453 LOperand* divisor = UseRegister(instr->right()); 1453 LOperand* divisor = UseRegister(instr->right());
1454 mod = new(zone()) LModI(dividend, 1454 mod = new(zone()) LModI(dividend,
1455 divisor, 1455 divisor,
1456 TempRegister(), 1456 TempRegister(),
1457 FixedTemp(d10), 1457 FixedTemp(d10),
1458 FixedTemp(d11)); 1458 FixedTemp(d11));
1459 } 1459 }
1460 1460
1461 if (instr->CheckFlag(HValue::kBailoutOnMinusZero) || 1461 if (instr->CheckFlag(HValue::kBailoutOnMinusZero) ||
1462 instr->CheckFlag(HValue::kCanBeDivByZero)) { 1462 instr->CheckFlag(HValue::kCanBeDivByZero) ||
1463 instr->CheckFlag(HValue::kCanOverflow)) {
1463 return AssignEnvironment(DefineAsRegister(mod)); 1464 return AssignEnvironment(DefineAsRegister(mod));
1464 } else { 1465 } else {
1465 return DefineAsRegister(mod); 1466 return DefineAsRegister(mod);
1466 } 1467 }
1467 } else if (instr->representation().IsTagged()) { 1468 } else if (instr->representation().IsTagged()) {
1468 return DoArithmeticT(Token::MOD, instr); 1469 return DoArithmeticT(Token::MOD, instr);
1469 } else { 1470 } else {
1470 ASSERT(instr->representation().IsDouble()); 1471 ASSERT(instr->representation().IsDouble());
1471 // We call a C function for double modulo. It can't trigger a GC. 1472 // We call a C function for double modulo. It can't trigger a GC.
1472 // We need to use fixed result register for the call. 1473 // We need to use fixed result register for the call.
(...skipping 1143 matching lines...) Expand 10 before | Expand all | Expand 10 after
2616 2617
2617 2618
2618 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2619 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2619 LOperand* object = UseRegister(instr->object()); 2620 LOperand* object = UseRegister(instr->object());
2620 LOperand* index = UseRegister(instr->index()); 2621 LOperand* index = UseRegister(instr->index());
2621 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2622 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2622 } 2623 }
2623 2624
2624 2625
2625 } } // namespace v8::internal 2626 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698