Load and send Wallet Risk params after user has agreed

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_view.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/autofill/browser/autofill_common_test.h"
 #include "components/autofill/browser/autofill_metrics.h"
+#include "components/autofill/browser/risk/proto/fingerprint.pb.h"
 #include "components/autofill/browser/test_personal_data_manager.h"
 #include "components/autofill/browser/wallet/full_wallet.h"
 #include "components/autofill/browser/wallet/instrument.h"
 #include "components/autofill/browser/wallet/wallet_address.h"
 #include "components/autofill/browser/wallet/wallet_client.h"
 #include "components/autofill/browser/wallet/wallet_test_util.h"
 #include "components/autofill/common/form_data.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/web_contents_tester.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_WIN)
 #include "ui/base/win/scoped_ole_initializer.h"
 #endif
 
 using testing::_;
 
 namespace autofill {
 
-namespace {

[Ilya Sherman, 2013/05/22 23:53:59]

Why did you remove this?  It should wrap everything other than
AutofillDialogControllerTest (which looks like it accidentally got tucked into
there).

[Dan Beam, 2013/05/23 00:30:40]

look at newer patchsets

-
 const char kFakeEmail[] = "user@example.com";
+const char kFakeFingerprintEncoded[] = "CgVaAwiACA==";
 const char kEditedBillingAddress[] = "123 edited billing address";
-const char* kFieldsFromPage[] = { "email", "cc-number", "billing region",
-  "shipping region" };
+const char* kFieldsFromPage[] =
+    { "email", "cc-number", "billing region", "shipping region" };
 const char kSettingsOrigin[] = "Chrome settings";
 
 using content::BrowserThread;
 
 void SetOutputValue(const DetailInputs& inputs,
                     DetailOutputMap* outputs,
                     AutofillFieldType type,
                     const std::string& value) {
   for (size_t i = 0; i < inputs.size(); ++i) {
     const DetailInput& input = inputs[i];
@@ skipping 162 matching lines @@
   void set_is_first_run(bool is_first_run) { is_first_run_ = is_first_run; }
 
   const GURL& open_tab_url() { return open_tab_url_; }
 
   virtual DialogType GetDialogType() const OVERRIDE {
     return dialog_type_;
   }
 
   void set_dialog_type(DialogType dialog_type) { dialog_type_ = dialog_type; }
 
+  MOCK_METHOD0(LoadRiskFingerprintData, void());
+
+  virtual void OnDidLoadRiskFingerprintData(
+      scoped_ptr<risk::Fingerprint> fingerprint) OVERRIDE {
+    AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData(
+        fingerprint.Pass());
+  }

[Ilya Sherman, 2013/05/22 23:53:59]

Optional nit: I think you can just write "using
AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData;" instead of lines
227-231.

[Dan Beam, 2013/05/23 00:30:40]

Done.

+
  protected:
   virtual PersonalDataManager* GetManager() OVERRIDE {
     return &test_manager_;
   }
 
   virtual wallet::WalletClient* GetWalletClient() OVERRIDE {
     return &test_wallet_client_;
   }
 
   virtual bool IsFirstRun() const OVERRIDE {
@@ skipping 43 matching lines @@
       form_data.fields.push_back(field);
     }
 
     profile()->CreateRequestContext();
     test_web_contents_.reset(
         content::WebContentsTester::CreateTestWebContents(profile(), NULL));
 
     base::Callback<void(const FormStructure*, const std::string&)> callback =
         base::Bind(&AutofillDialogControllerTest::FinishedCallback,
                    base::Unretained(this));
-    controller_ = (new TestAutofillDialogController(
+    controller_ = (new testing::NiceMock<TestAutofillDialogController>(
         test_web_contents_.get(),
         form_data,
         GURL(),
         metric_logger_,
         DIALOG_TYPE_REQUEST_AUTOCOMPLETE,
         callback))->AsWeakPtr();
     controller_->Init(profile());
     controller_->Show();
     controller_->OnUserNameFetchSuccess(kFakeEmail);
   }
 
   virtual void TearDown() OVERRIDE {
     if (controller_)
       controller_->ViewClosed();
   }
 
  protected:
   static scoped_ptr<wallet::FullWallet> CreateFullWalletWithVerifyCvv() {
     base::DictionaryValue dict;
     scoped_ptr<base::ListValue> list(new base::ListValue());
     list->AppendString("verify_cvv");
     dict.Set("required_action", list.release());
     return wallet::FullWallet::CreateFullWallet(dict);
   }
 
+  static scoped_ptr<risk::Fingerprint> GetFakeFingerprint() {
+    scoped_ptr<risk::Fingerprint> fingerprint(new risk::Fingerprint());
+    // Add some data to the proto, else the encoded content is empty.
+    fingerprint->mutable_machine_characteristics()->mutable_screen_size()->
+        set_width(1024);
+    return fingerprint.Pass();
+  }

[Ilya Sherman, 2013/05/22 23:53:59]

nit: Please define this as a free function rather than a static class method.

[Dan Beam, 2013/05/23 00:30:40]

Done.

+
   void FillCreditCardInputs() {
     DetailOutputMap cc_outputs;
     const DetailInputs& cc_inputs =
         controller()->RequestedFieldsForSection(SECTION_CC);
     for (size_t i = 0; i < cc_inputs.size(); ++i) {
       cc_outputs[&cc_inputs[i]] = ASCIIToUTF16("11");
     }
     controller()->GetView()->SetUserInput(SECTION_CC, cc_outputs);
   }
 
@@ skipping 52 matching lines @@
 
   // Must outlive the controller.
   AutofillMetrics metric_logger_;
 
   // Returned when the dialog closes successfully.
   const FormStructure* form_structure_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerTest);
 };
 
-}  // namespace
-
 // This test makes sure nothing falls over when fields are being validity-
 // checked.
 TEST_F(AutofillDialogControllerTest, ValidityCheck) {
   const DialogSection sections[] = {
     SECTION_EMAIL,
     SECTION_CC,
     SECTION_BILLING,
     SECTION_CC_BILLING,
     SECTION_SHIPPING
   };
@@ skipping 202 matching lines @@
   EXPECT_EQ("CA", UTF16ToUTF8(form_structure()->field(3)->value));
   EXPECT_EQ(ADDRESS_BILLING_STATE, form_structure()->field(2)->type());
   EXPECT_EQ(ADDRESS_HOME_STATE, form_structure()->field(3)->type());
 }
 
 TEST_F(AutofillDialogControllerTest, AcceptLegalDocuments) {
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               AcceptLegalDocuments(_, _, _)).Times(1);
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               GetFullWallet(_)).Times(1);
+  EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(1);
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddLegalDocument(wallet::GetTestLegalDocument());
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
   controller()->OnAccept();
+  controller()->OnDidAcceptLegalDocuments();
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
 }
 
 // Makes sure the default object IDs are respected.
 TEST_F(AutofillDialogControllerTest, WalletDefaultItems) {
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestNonDefaultMaskedInstrument());
   wallet_items->AddInstrument(wallet::GetTestNonDefaultMaskedInstrument());
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddInstrument(wallet::GetTestNonDefaultMaskedInstrument());
 
@@ skipping 308 matching lines @@
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               GetFullWallet(_)).Times(1);
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               AuthenticateInstrument(_, _, _)).Times(1);
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
   controller()->OnAccept();
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
 
   EXPECT_TRUE(NotificationsOfType(DialogNotification::REQUIRED_ACTION).empty());
   EXPECT_TRUE(controller()->SectionIsActive(SECTION_SHIPPING));
   EXPECT_TRUE(controller()->SectionIsActive(SECTION_CC_BILLING));
   EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 
   SuggestionState suggestion_state =
       controller()->SuggestionStateForSection(SECTION_CC_BILLING);
   EXPECT_TRUE(suggestion_state.extra_text.empty());
@@ skipping 18 matching lines @@
 
 TEST_F(AutofillDialogControllerTest, ErrorDuringSubmit) {
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               GetFullWallet(_)).Times(1);
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
   controller()->OnAccept();
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
 
   EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 
   controller()->OnWalletError(wallet::WalletClient::UNKNOWN_ERROR);
 
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 }
 
 // TODO(dbeam): disallow changing accounts instead and remove this test.
 TEST_F(AutofillDialogControllerTest, ChangeAccountDuringSubmit) {
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               GetFullWallet(_)).Times(1);
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
   controller()->OnAccept();
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
 
   EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 
   SwitchToWallet();
   SwitchToAutofill();
 
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 }
 
 TEST_F(AutofillDialogControllerTest, ErrorDuringVerifyCvv) {
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               GetFullWallet(_)).Times(1);
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
   controller()->OnAccept();
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
   controller()->OnDidGetFullWallet(CreateFullWalletWithVerifyCvv());
 
   ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 
   controller()->OnWalletError(wallet::WalletClient::UNKNOWN_ERROR);
 
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 }
 
 // TODO(dbeam): disallow changing accounts instead and remove this test.
 TEST_F(AutofillDialogControllerTest, ChangeAccountDuringVerifyCvv) {
   EXPECT_CALL(*controller()->GetTestingWalletClient(),
               GetFullWallet(_)).Times(1);
 
   scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
   wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
   wallet_items->AddAddress(wallet::GetTestShippingAddress());
   controller()->OnDidGetWalletItems(wallet_items.Pass());
   controller()->OnAccept();
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
   controller()->OnDidGetFullWallet(CreateFullWalletWithVerifyCvv());
 
   ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
 
   SwitchToWallet();
   SwitchToAutofill();
 
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
   EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
@@ skipping 251 matching lines @@
   controller()->EditCancelledForSection(SECTION_EMAIL);
   EXPECT_FALSE(controller()->ShouldOfferToSaveInChrome());
 
   controller()->MenuModelForSection(SECTION_EMAIL)->ActivatedAt(1);
   EXPECT_TRUE(controller()->ShouldOfferToSaveInChrome());
 
   profile()->set_incognito(true);
   EXPECT_FALSE(controller()->ShouldOfferToSaveInChrome());
 }
 
+TEST_F(AutofillDialogControllerTest, RiskNeverLoadsWithPendingLegalDocuments) {
+  EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(0);
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddLegalDocument(wallet::GetTestLegalDocument());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+
+  EXPECT_EQ("risky business", controller()->GetRiskData());

[Ilya Sherman, 2013/05/22 23:53:59]

Should this test call controller()->OnAccept(); before this, to give a bit more
coverage?

[Dan Beam, 2013/05/23 00:30:40]

Done.

+}
+
+TEST_F(AutofillDialogControllerTest, RiskLoadsWithoutPendingLegalDocuments) {
+  EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(1);
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddInstrument(wallet::GetTestMaskedInstrument());
+  wallet_items->AddAddress(wallet::GetTestShippingAddress());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+  controller()->OnAccept();
+
+  EXPECT_EQ("risky business", controller()->GetRiskData());
+
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
+  EXPECT_EQ(kFakeFingerprintEncoded, controller()->GetRiskData());
+}
+
+TEST_F(AutofillDialogControllerTest, RiskLoadsAfterAcceptingLegalDocuments) {
+  EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(0);
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddLegalDocument(wallet::GetTestLegalDocument());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+
+  testing::Mock::VerifyAndClear(controller());
+  EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(1);
+
+  controller()->OnAccept();
+  EXPECT_EQ("risky business", controller()->GetRiskData());
+
+  // Simulate a risk load and verify |GetRiskData()| matches the encoded value.
+  controller()->OnDidAcceptLegalDocuments();
+  controller()->OnDidLoadRiskFingerprintData(GetFakeFingerprint().Pass());
+  EXPECT_EQ(kFakeFingerprintEncoded, controller()->GetRiskData());
+}
+
 }  // namespace autofill