Load and send Wallet Risk params after user has agreed

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 
 #include <map>
 #include <vector>
 
 #include "base/callback.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "chrome/browser/ui/autofill/account_chooser_model.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "chrome/browser/ui/autofill/country_combobox_model.h"
@@ skipping 236 matching lines @@
   // Call to disable communication to Online Wallet for this dialog.
   // Exposed for testing.
   void DisableWallet();
 
   // Returns whether Wallet is the current data source. Exposed for testing.
   virtual bool IsPayingWithWallet() const;
 
   // Exposed and virtual for testing.
   virtual bool IsFirstRun() const;
 
+  // Asks risk module to asynchronously load fingerprint data. Data will be
+  // returned via |OnDidLoadRiskFingerprintData()|. Exposed for testing.
+  virtual void LoadRiskFingerprintData();
+
   // Opens the given URL in a new foreground tab.
   virtual void OpenTabWithUrl(const GURL& url);
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest, AcceptLegalDocuments);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest, VerifyCvv);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest, ErrorDuringSubmit);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest, ErrorDuringVerifyCvv);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           ChangeAccountDuringSubmit);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           ChangeAccountDuringVerifyCvv);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           RiskLoadsWithoutPendingLegalDocuments);
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           RiskLoadsAfterAcceptingLegalDocuments);

[Ilya Sherman, 2013/05/22 22:34:24]

Rather than adding lots of friend tests, please up the visibility of
OnDidLoadRiskFingerprintData() to be protected.

[Dan Beam, 2013/05/22 23:25:20]

Done.

+
   // Whether or not the current request wants credit info back.
   bool RequestingCreditCardInfo() const;
 
   // Whether the information input in this dialog will be securely transmitted
   // to the requesting site.
   bool TransmissionWillBeSecure() const;
 
   // Initializes |suggested_email_| et al.
   void SuggestionsUpdated();
 
@@ skipping 90 matching lines @@
       std::vector<string16>* popup_values,
       std::vector<string16>* popup_labels,
       std::vector<string16>* popup_icons);
 
   // Like RequestedFieldsForSection, but returns a pointer.
   DetailInputs* MutableRequestedFieldsForSection(DialogSection section);
 
   // Hides |popup_controller_|'s popup view, if it exists.
   void HidePopup();
 
-  // Asks risk module to asynchronously load fingerprint data. Data will be
-  // returned via OnDidLoadRiskFingerprintData.
-  void LoadRiskFingerprintData();
+  // Called when loading of risk fingerprint data is done.
   void OnDidLoadRiskFingerprintData(scoped_ptr<risk::Fingerprint> fingerprint);
 
   // Whether the user has chosen to enter all new data in |section|. This
   // happens via choosing "Add a new X..." from a section's suggestion menu.
   bool IsManuallyEditingSection(DialogSection section) const;
 
   // Whether the user has chosen to enter all new data in at least one section.
   bool IsManuallyEditingAnySection() const;
 
   // Returns true if the |value| is a valid string for the given autofill field
@@ skipping 15 matching lines @@
   // Whether the billing section should be used to fill in the shipping details.
   bool ShouldUseBillingForShipping();
 
   // Whether the user wishes to save information locally to Autofill.
   bool ShouldSaveDetailsLocally();
 
   // Change whether the controller is currently submitting details to Autofill
   // or Online Wallet (|is_submitting_|) and update the view.
   void SetIsSubmitting(bool submitting);
 
+  // Whether the user has accepted all the current legal documents' terms.
+  bool LegalDocumentsAreCurrent() const;
+
   // Start the submit proccess to interact with Online Wallet (might do various
   // things like accept documents, save details, update details, respond to
   // required actions, etc.).
   void SubmitWithWallet();
 
   // Creates an instrument based on |views_|' contents.
   scoped_ptr<wallet::Instrument> CreateTransientInstrument();
 
   // Creates an update request based on |instrument|. May return NULL.
   scoped_ptr<wallet::WalletClient::UpdateInstrumentRequest>
       CreateUpdateInstrumentRequest(const wallet::Instrument* instrument,
                                     const std::string& instrument_id);
 
   // Creates an address based on the contents of |view_|.
   scoped_ptr<wallet::Address> CreateTransientAddress();
 
-  // Gets a full wallet from Online Wallet so the user can purchase something.
+  // Gets a full wallet from Online Wallet so the user can purchase something if

[Ilya Sherman, 2013/05/22 22:34:24]

nit: Spurious diff.

[Dan Beam, 2013/05/22 23:25:20]

Done.

   // This information is decoded to reveal a fronting (proxy) card.
   void GetFullWallet();
 
+  // Calls |GetFullWallet()| if the required members (|risk_data_|,
+  // |active_instrument_id_|, and |active_address_id_|) are populated.
+  void GetFullWalletIfReady();
+
   // Updates the state of the controller and |view_| based on any required
   // actions returned by Save or Update calls to Wallet.
   void HandleSaveOrUpdateRequiredActions(
       const std::vector<wallet::RequiredAction>& required_actions);
 
   // Whether submission is currently waiting for |action| to be handled.
   bool IsSubmitPausedOn(wallet::RequiredAction action) const;
 
   // Called when there's nothing left to accept, update, save, or authenticate
   // in order to fill |form_structure_| and pass data back to the invoking page.
@@ skipping 61 matching lines @@
   // The helper is set only during fetch/sign-in, and NULL otherwise.
   scoped_ptr<wallet::WalletSigninHelper> signin_helper_;
 
   // A client to talk to the Online Wallet API.
   wallet::WalletClient wallet_client_;
 
   // Recently received items retrieved via |wallet_client_|.
   scoped_ptr<wallet::WalletItems> wallet_items_;
   scoped_ptr<wallet::FullWallet> full_wallet_;
 
+  // Local machine signals to pass along on each request to trigger (or
+  // discourage) risk challenges; sent if the user is up to date on legal docs.
+  std::string risk_data_;
+
   // The text to display when the user is accepting new terms of service, etc.
   string16 legal_documents_text_;
   // The ranges within |legal_documents_text_| to linkify.
   std::vector<ui::Range> legal_document_link_ranges_;
 
   // The instrument and address IDs from the Online Wallet server to be used
   // when getting a full wallet.
   std::string active_instrument_id_;
   std::string active_address_id_;
 
@@ skipping 36 matching lines @@
   scoped_ptr<AutofillDialogView> view_;
 
   // A NotificationRegistrar for tracking the completion of sign-in.
   content::NotificationRegistrar signin_registrar_;
 
   base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_;
 
   // Whether this is the first time this profile has seen the Autofill dialog.
   bool is_first_run_;
 
+  // Whether a user accepted legal documents while this dialog is running.
+  bool accepted_legal_documents_;

[Ilya Sherman, 2013/05/22 22:34:24]

nit: "has_accepted_..."

[Dan Beam, 2013/05/22 23:25:20]

Done.

+
   // True after the user first accepts the dialog and presses "Submit". May
   // continue to be true while processing required actions.
   bool is_submitting_;
 
   // Whether or not there was a server side validation error saving or updating
   // Wallet data.
   bool wallet_server_validation_error_;
 
   // The current state of the Autocheckout flow.
   AutocheckoutState autocheckout_state_;
 
   // Whether the latency to display to the UI was logged to UMA yet.
   bool was_ui_latency_logged_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_