Load and send Wallet Risk params after user has agreed

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 
 #include <map>
 #include <vector>
 
 #include "base/callback.h"
+#include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "chrome/browser/ui/autofill/account_chooser_model.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "chrome/browser/ui/autofill/country_combobox_model.h"
@@ skipping 224 matching lines @@
   // Call to disable communication to Online Wallet for this dialog.
   // Exposed for testing.
   void DisableWallet();
 
   // Returns whether Wallet is the current data source. Exposed for testing.
   virtual bool IsPayingWithWallet() const;
 
   // Exposed and virtual for testing.
   virtual bool IsFirstRun() const;
 
+  // Asks risk module to asynchronously load fingerprint data. Data will be
+  // returned via |OnDidLoadRiskFingerprintData()|. Exposed for testing.
+  virtual void LoadRiskFingerprintData();
+
+  // Basically exists for testing, which is why |fingerprint| is a pointer
+  // rather than const-ref (as it can be NULL this way).

[Ilya Sherman, 2013/05/03 07:38:31]

This comment doesn't actually describe what the method does.  Also, why is it
important for the |fingerprint| to possibly be NULL in tests?

[Dan Beam, 2013/05/03 09:24:47]

It has no good use outside of testing and I want to be able to easily control
the serialized value.

+  virtual void SerializeFingerprint(risk::Fingerprint* fingerprint,
+                                    std::string* data);
+
  private:
+  FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerTest,
+                           LoadRiskWhenNoLegalDocs);
+
   // Whether or not the current request wants credit info back.
   bool RequestingCreditCardInfo() const;
 
   // Whether the information input in this dialog will be securely transmitted
   // to the requesting site.
   bool TransmissionWillBeSecure() const;
 
   // Initializes |suggested_email_| et al.
   void SuggestionsUpdated();
 
@@ skipping 86 matching lines @@
       std::vector<string16>* popup_values,
       std::vector<string16>* popup_labels,
       std::vector<string16>* popup_icons);
 
   // Like RequestedFieldsForSection, but returns a pointer.
   DetailInputs* MutableRequestedFieldsForSection(DialogSection section);
 
   // Hides |popup_controller_|'s popup view, if it exists.
   void HidePopup();
 
-  // Asks risk module to asynchronously load fingerprint data. Data will be
-  // returned via OnDidLoadRiskFingerprintData.
-  void LoadRiskFingerprintData();
+  // Called when loading of risk fingerprint data is done.
   void OnDidLoadRiskFingerprintData(scoped_ptr<risk::Fingerprint> fingerprint);
 
   // Whether the user has chosen to enter all new data in |section|. This
   // happens via choosing "Add a new X..." from a section's suggestion menu.
   bool IsManuallyEditingSection(DialogSection section) const;
 
   // Whether the user has chosen to enter all new data in at least one section.
   bool IsManuallyEditingAnySection() const;
 
   // Whether all of the input fields currently showing in the dialog have valid
@@ skipping 96 matching lines @@
   // The helper is set only during fetch/sign-in, and NULL otherwise.
   scoped_ptr<wallet::WalletSigninHelper> signin_helper_;
 
   // A client to talk to the Online Wallet API.
   wallet::WalletClient wallet_client_;
 
   // Recently received items retrieved via |wallet_client_|.
   scoped_ptr<wallet::WalletItems> wallet_items_;
   scoped_ptr<wallet::FullWallet> full_wallet_;
 
+  // Local machine signals to pass along on each request to trigger (or
+  // discourage) risk challenges; sent if the user's up to date on legal docs.

[Ilya Sherman, 2013/05/03 07:38:31]

nit: "user's" -> "user is" IMO

[Dan Beam, 2013/05/03 23:02:40]

Done.

+  std::string risk_data_;
+
   // The text to display when the user is accepting new terms of service, etc.
   string16 legal_documents_text_;
   // The ranges within |legal_documents_text_| to linkify.
   std::vector<ui::Range> legal_document_link_ranges_;
 
   // Used to remember the state of Wallet comboboxes when Submit was clicked.
   std::string active_instrument_id_;
   std::string active_address_id_;
 
   // The fields for billing and shipping which the page has actually requested.
@@ skipping 35 matching lines @@
   scoped_ptr<AutofillDialogView> view_;
 
   // A NotificationRegistrar for tracking the completion of sign-in.
   content::NotificationRegistrar registrar_;
 
   base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_;
 
   // Whether this is the first time this profile has seen the Autofill dialog.
   bool is_first_run_;
 
+  // Whether a user's legal documents are up to date.
+  bool legal_docs_current_;

[Ilya Sherman, 2013/05/03 07:38:31]

nit: "legal_docs_are_current_" or "are_legal_docs_current_"

[Dan Beam, 2013/05/03 23:02:40]

Done.

+
   // True after the user first accepts the dialog and presses "Submit". May
   // continue to be true while processing required actions.
   bool is_submitting_;
 
   // Whether or not an Autocheckout flow is running.
   bool autocheckout_is_running_;
 
   // Whether or not there was an error in the Autocheckout flow.
   bool had_autocheckout_error_;
 
   // Whether the latency to display to the UI was logged to UMA yet.
   bool was_ui_latency_logged_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_