Load and send Wallet Risk params after user has agreed

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <string>
 
+#include "base/base64.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 1391 matching lines @@
 
 const AutofillMetrics& AutofillDialogControllerImpl::GetMetricLogger() const {
   return metric_logger_;
 }
 
 DialogType AutofillDialogControllerImpl::GetDialogType() const {
   return dialog_type_;
 }
 
 std::string AutofillDialogControllerImpl::GetRiskData() const {
-  // TODO(dbeam): Implement this.
-  return "risky business";
+  // TODO(dbeam): remove the server restriction that this must not be empty.
+  return risk_data_.empty() ? "risky business" : risk_data_;

[Ilya Sherman, 2013/05/03 07:38:31]

Why can risk_data_ be empty?  We shouldn't issue requests that require risk data
until it's loaded.

[Dan Beam, 2013/05/03 09:24:47]

Failed encoding, not loaded yet (there's nothing to say that risk loads first).

[Ilya Sherman, 2013/05/07 00:59:30]

We should structure the code so that it's guaranteed that risk data is loaded by
the time anyone needs to call GetRiskData().  Likewise, we should structure the
code so that it's not possible for the encoding to fail.

If either of the above goes wrong, then we don't have risk data to offer the
server, which essentially means we're a misbehaving client.  It seems pretty
appropriate for the server to reject requests from misbehaving clients.

 }
 
 void AutofillDialogControllerImpl::OnDidAcceptLegalDocuments() {
-  // TODO(dbeam): Don't send risk params until legal documents are accepted:
-  // http://crbug.com/173505
+  legal_docs_current_ = true;
+  LoadRiskFingerprintData();
 }
 
 void AutofillDialogControllerImpl::OnDidAuthenticateInstrument(bool success) {
   DCHECK(is_submitting_ && IsPayingWithWallet());
 
   // TODO(dbeam): use the returned full wallet. b/8332329
   if (success)
     GetFullWallet();
   else
     DisableWallet();
@@ skipping 58 matching lines @@
 }
 
 void AutofillDialogControllerImpl::OnDidGetWalletItems(
     scoped_ptr<wallet::WalletItems> wallet_items) {
   DCHECK(account_chooser_model_.WalletIsSelected());
   legal_documents_text_.clear();
   legal_document_link_ranges_.clear();
 
   // TODO(dbeam): verify items support kCartCurrency? http://crbug.com/232952
   wallet_items_ = wallet_items.Pass();
+
+  legal_docs_current_ = wallet_items_->legal_documents().empty();
+  if (legal_docs_current_)
+    LoadRiskFingerprintData();
+
   OnWalletOrSigninUpdate();
 }
 
 void AutofillDialogControllerImpl::OnDidSaveAddress(
     const std::string& address_id,
     const std::vector<wallet::RequiredAction>& required_actions) {
   // TODO(dbeam): handle required actions. http://crbug.com/163508
   active_address_id_ = address_id;
   GetFullWallet();
 }
@@ skipping 179 matching lines @@
 
 bool AutofillDialogControllerImpl::IsPayingWithWallet() const {
   return account_chooser_model_.WalletIsSelected() &&
          SignedInState() == SIGNED_IN;
 }
 
 bool AutofillDialogControllerImpl::IsFirstRun() const {
   return is_first_run_;
 }
 
+void AutofillDialogControllerImpl::LoadRiskFingerprintData() {
+  if (!legal_docs_current_)
+    return;

[Ilya Sherman, 2013/05/03 07:38:31]

Can this be a DCHECK instead?

[Dan Beam, 2013/05/03 09:24:47]

A DCHECK() is not a strong assurance in release builds or when half the devs
don't build with them on ;).

[Ilya Sherman, 2013/05/07 00:59:30]

DCHECKs are used to document expected state.  Unless there are expected code
paths that could reach here with |legal_docs_current_| being false, please make
this a DCHECK.

I don't really understand why Evan builds with DCHECKs off, but that doesn't
mean that our code should be different from how most other Chrome code is
structured.

[Dan Beam, 2013/05/07 04:02:50]

Done.

+
+  uint64 obfuscated_gaia_id = 0;
+  bool success = base::StringToUint64(wallet_items_->obfuscated_gaia_id(),
+                                      &obfuscated_gaia_id);
+  DCHECK(success);
+
+  gfx::Rect window_bounds =
+      GetBaseWindowForWebContents(web_contents())->GetBounds();
+
+  PrefService* user_prefs = profile_->GetPrefs();
+  std::string charset = user_prefs->GetString(::prefs::kDefaultCharset);
+  std::string accept_languages =
+      user_prefs->GetString(::prefs::kAcceptLanguages);
+  base::Time install_time = base::Time::FromTimeT(
+      g_browser_process->local_state()->GetInt64(::prefs::kInstallDate));
+
+  risk::GetFingerprint(
+      obfuscated_gaia_id, window_bounds, *web_contents(),
+      chrome::VersionInfo().Version(), charset, accept_languages, install_time,
+      dialog_type_, g_browser_process->GetApplicationLocale(),
+      base::Bind(&AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData,
+                 weak_ptr_factory_.GetWeakPtr()));
+}
+
+void AutofillDialogControllerImpl::SerializeFingerprint(
+    risk::Fingerprint* fingerprint, std::string* data) {
+  fingerprint->SerializeToString(data);
+}
+
 void AutofillDialogControllerImpl::DisableWallet() {
   signin_helper_.reset();
   account_chooser_model_.SetHadWalletError();
   GetWalletClient()->CancelRequests();
   wallet_items_.reset();
   full_wallet_.reset();
   SetIsSubmitting(false);
 }
 
 void AutofillDialogControllerImpl::SuggestionsUpdated() {
@@ skipping 301 matching lines @@
     DialogSection section) {
   return const_cast<DetailInputs*>(&RequestedFieldsForSection(section));
 }
 
 void AutofillDialogControllerImpl::HidePopup() {
   if (popup_controller_)
     popup_controller_->Hide();
   input_showing_popup_ = NULL;
 }
 
-void AutofillDialogControllerImpl::LoadRiskFingerprintData() {
-  // TODO(dbeam): Add a CHECK or otherwise strong guarantee that the ToS have
-  // been accepted prior to calling into this method. Also, ensure that the UI
-  // contains a clear indication to the user as to what data will be collected.
-  // Until then, this code should not be called. http://crbug.com/173505
-
-  int64 gaia_id = 0;
-  bool success =
-      base::StringToInt64(wallet_items_->obfuscated_gaia_id(), &gaia_id);
-  DCHECK(success);
-
-  gfx::Rect window_bounds =
-      GetBaseWindowForWebContents(web_contents())->GetBounds();
-
-  PrefService* user_prefs = profile_->GetPrefs();
-  std::string charset = user_prefs->GetString(::prefs::kDefaultCharset);
-  std::string accept_languages =
-      user_prefs->GetString(::prefs::kAcceptLanguages);
-  base::Time install_time = base::Time::FromTimeT(
-      g_browser_process->local_state()->GetInt64(::prefs::kInstallDate));
-
-  risk::GetFingerprint(
-      gaia_id, window_bounds, *web_contents(), chrome::VersionInfo().Version(),
-      charset, accept_languages, install_time, dialog_type_,
-      g_browser_process->GetApplicationLocale(),
-      base::Bind(&AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData,
-                 weak_ptr_factory_.GetWeakPtr()));
-}
-
 void AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData(
     scoped_ptr<risk::Fingerprint> fingerprint) {
-  NOTIMPLEMENTED();
+  if (!legal_docs_current_)
+    return;
+
+  std::string proto_data;
+  SerializeFingerprint(fingerprint.get(), &proto_data);
+
+  if (!base::Base64Encode(proto_data, &risk_data_))

[Dan Beam, 2013/05/03 07:29:09]

btw, I have no idea how this could fail, but it doesn't hurt... I guess....

[Ilya Sherman, 2013/05/03 07:38:31]

Yeah, I'm also uncertain.  I think a DCHECK might be reasonable.

[Dan Beam, 2013/05/03 09:24:47]

Maybe for this... I just don't understand why this returns a bool...

+    risk_data_.clear();
 }
 
 bool AutofillDialogControllerImpl::IsManuallyEditingSection(
     DialogSection section) const {
   std::map<DialogSection, bool>::const_iterator it =
       section_editing_state_.find(section);
   return (it != section_editing_state_.end() && it->second) ||
          SuggestionsMenuModelForSection(section)->
              GetItemKeyForCheckedItem() == kAddNewItemKey;
 }
@@ skipping 316 matching lines @@
       url,
       content::PAGE_TRANSITION_AUTO_BOOKMARK);
   params.disposition = NEW_FOREGROUND_TAB;
   chrome::Navigate(&params);
 #else
   // TODO(estade): use TabModelList?
 #endif
 }
 
 }  // namespace autofill