PRESUBMIT.py - Issue 1490383004: Make DISALLOW_* presubmit stricter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1490383004: Make DISALLOW_* presubmit stricter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 4e1edcc620898423aa36c5f0e184342d5cc9be5a..9ffcd84fc39b56762de0aeeed1caa9d71dfc144c 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1540,7 +1540,13 @@ def _CheckSingletonInHeaders(input_api, output_api):

def _CheckBaseMacrosInHeaders(input_api, output_api):

"""Check for base/macros.h if DISALLOW_* macro is used."""

- disallows = ('DISALLOW_ASSIGN', 'DISALLOW_COPY', 'DISALLOW_EVIL')

+ disallows = (

+ 'DISALLOW_ASSIGN(',

+ 'DISALLOW_COPY(',

+ 'DISALLOW_COPY_AND_ASSIGN(',

+ 'DISALLOW_EVIL_CONSTRUCTORS(',

Nico 2015/12/04 21:42:56 fwiw i removed DISALLOW_EVIL_CTORS from macros.h e

Dan Beam 2015/12/04 22:53:02 look down, look back THE PRESUBMIT IS NOW GONE h

+ 'DISALLOW_IMPLICIT_CONSTRUCTORS(',

+ )

macros = '#include "base/macros.h"'

basictypes = '#include "base/basictypes.h"'

« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | no next file with comments »