Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1490363003: PPC: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). Port 411c5b7fb09f76fca567c3deda3304f77eb3df2f Original commit message: Also remove the ResultMode from ToBooleanStub and always return true or false and use the same mechanism in fullcodegen. This is in preparation for adding ToBoolean hints to TurboFan. Drive-by-fix: We can use the power of the ToBooleanIC in TurboFan now that the ResultMode is gone (and the runtime always returns true or false from the miss handler). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4583 LOG=n Committed: https://crrev.com/65d28d70cddf6bd757102368cf6716b5fd83005b Cr-Commit-Position: refs/heads/master@{#32531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
5 years ago (2015-12-02 19:23:16 UTC) #1
michael_dawson
On 2015/12/02 19:23:16, mtbrandyberry wrote: lgtm
5 years ago (2015-12-02 21:10:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490363003/1
5 years ago (2015-12-02 21:12:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 21:37:43 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-02 21:40:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65d28d70cddf6bd757102368cf6716b5fd83005b
Cr-Commit-Position: refs/heads/master@{#32531}

Powered by Google App Engine
This is Rietveld 408576698