content/common/gpu/media/android_copying_backing_strategy.h - Issue 1490333005: Don't require VDAs to return all PictureBuffers at once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/android_copying_backing_strategy.h

Issue 1490333005: Don't require VDAs to return all PictureBuffers at once. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bot failures, cl feedback. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/gpu_messages.h ('k') | content/common/gpu/media/android_copying_backing_strategy.cc » ('j') | media/video/video_decode_accelerator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/android_copying_backing_strategy.h

diff --git a/content/common/gpu/media/android_copying_backing_strategy.h b/content/common/gpu/media/android_copying_backing_strategy.h

index 4cb1f622a5a30f1f2c46eddd1e17f6a8a4de9a75..d728b4876edfc0017097f14f20757f80c0d3e603 100644

--- a/content/common/gpu/media/android_copying_backing_strategy.h

+++ b/content/common/gpu/media/android_copying_backing_strategy.h

@@ -32,7 +32,6 @@ class CONTENT_EXPORT AndroidCopyingBackingStrategy

// AndroidVideoDecodeAccelerator::BackingStrategy

void Initialize(AVDAStateProvider*) override;

void Cleanup(const AndroidVideoDecodeAccelerator::OutputBufferMap&) override;

- uint32 GetNumPictureBuffers() const override;

uint32 GetTextureTarget() const override;

scoped_refptr<gfx::SurfaceTexture> CreateSurfaceTexture() override;

void UseCodecBufferForPictureBuffer(int32 codec_buffer_index,

@@ -41,6 +40,11 @@ class CONTENT_EXPORT AndroidCopyingBackingStrategy

media::VideoCodecBridge*,

const AndroidVideoDecodeAccelerator::OutputBufferMap&) override;

+ static media::VideoDecodeAccelerator::Capabilities::Flags

+ GetCapabilitiesFlags() {

+ return media::VideoDecodeAccelerator::Capabilities::kNoFlags;

+ }

private:

// Used for copy the texture from surface texture to picture buffers.

scoped_ptr<gpu::CopyTextureCHROMIUMResourceManager> copier_;