Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: content/common/gpu/media/android_deferred_rendering_backing_strategy.cc

Issue 1490333005: Don't require VDAs to return all PictureBuffers at once. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved flags into VDA::Capabilities. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/android_deferred_rendering_backing_strategy.cc
diff --git a/content/common/gpu/media/android_deferred_rendering_backing_strategy.cc b/content/common/gpu/media/android_deferred_rendering_backing_strategy.cc
index 78472bc239bf977ca90a00591afb4aa504cd515a..4dd9047ebee96cddf1ac83bf1d940350e07a1806 100644
--- a/content/common/gpu/media/android_deferred_rendering_backing_strategy.cc
+++ b/content/common/gpu/media/android_deferred_rendering_backing_strategy.cc
@@ -18,10 +18,12 @@
namespace content {
-// TODO(liberato): This is an entirely made-up number. It depends on how
-// many decoded buffers that the MediaCodec is willing to have outstanding
-// at any one time. Only one is guaranteed. crbug.com/531606.
-enum { kNumPictureBuffers = 3 };
+// This is the maximum number of pictures that we will allow to be outstanding
+// at once. We might not be able to support this many in all circumstances,
+// depending on how many decoded buffers the MediaCodec is willing to
+// give us. Only one is guaranteed. However, we also indicate in our
+// capabilities that we make no guarantees about it, so this is okay.
+enum { kNumPictureBuffers = 4 };
DaleCurtis 2015/12/04 18:40:13 Should this be limits:kMaxFrames + 1 like in the c
liberato (no reviews please) 2015/12/04 18:50:04 done, and removed GetNumPictureBuffers.
AndroidDeferredRenderingBackingStrategy::
AndroidDeferredRenderingBackingStrategy()

Powered by Google App Engine
This is Rietveld 408576698