Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: media/filters/gpu_video_decoder.h

Issue 1490333005: Don't require VDAs to return all PictureBuffers at once. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/gpu_video_decoder.h
diff --git a/media/filters/gpu_video_decoder.h b/media/filters/gpu_video_decoder.h
index 065ac38d068abecdea8bdc5b769fd6fbec54f915..f44458fdb993615c62529a16565daade797d05e1 100644
--- a/media/filters/gpu_video_decoder.h
+++ b/media/filters/gpu_video_decoder.h
@@ -136,8 +136,12 @@ class MEDIA_EXPORT GpuVideoDecoder
void DestroyPictureBuffers(PictureBufferMap* buffers);
// Returns true if the video decoder can support |profile| and |coded_size|.
- bool IsProfileSupported(VideoCodecProfile profile,
- const gfx::Size& coded_size);
+ // On success, |matching_profile_out| contains a copy of the matching
+ // profile. On failure, it is undefined.
+ bool IsProfileSupported(
+ VideoCodecProfile profile,
+ const gfx::Size& coded_size,
+ VideoDecodeAccelerator::SupportedProfile& matching_profile_out);
Pawel Osciak 2015/12/04 11:09:45 Non-const reference arguments are prohibited by co
liberato (no reviews please) 2015/12/04 18:28:58 Done.
// Assert the contract that this class is operated on the right thread.
void DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent() const;
@@ -203,6 +207,11 @@ class MEDIA_EXPORT GpuVideoDecoder
// HasAvailableOutputFrames().
int available_pictures_;
+ // If false, then we may assume that the VDA cannot stall sending picture
+ // buffers until all of them have decoded frames. If true, then it may
+ // stall as long as one picture buffer is outstanding.
+ bool can_stall_anytime_;
+
// Bound to factories_->GetMessageLoop().
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<GpuVideoDecoder> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698