Don't require VDAs to return all PictureBuffers at once.

media/video/video_decode_accelerator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 16 matching lines @@
   // |max_resolution| and |min_resolution| are inclusive.
   struct MEDIA_EXPORT SupportedProfile {
     SupportedProfile();
     ~SupportedProfile();
     VideoCodecProfile profile;
     gfx::Size max_resolution;
     gfx::Size min_resolution;
   };
   using SupportedProfiles = std::vector<SupportedProfile>;
 
+  struct MEDIA_EXPORT Capabilities {
+    Capabilities();
+    ~Capabilities();
+    // Flags that can be associated with a VDA.
+    enum Flags {

[dcheng, 2015/12/10 07:09:48]

Is there a convention around sizing the enum explicitly if you're going to use
it as a bitset on an explicitly sized int?

[liberato (no reviews please), 2015/12/10 15:56:06]

i didn't see anything in the style guide about it.  existing code has examples
both ways, didn't see a clear winner.  keeping as is for now.

+      NO_FLAGS = 0,
+
+      // Normally, the VDA is required to be able to provide all PictureBuffers
+      // to the client via PictureReady(), even if the client does not return
+      // any of them via ReusePictureBuffer().  The client is only required to
+      // return PictureBuffers when it holds all of them, if it wants to get
+      // more decoded output.  See VideoDecoder::CanReadWithoutStalling for
+      // more context.
+      // If this flag is set, then the VDA does not make this guarantee.  The
+      // client must return PictureBuffers to be sure that new frames will be
+      // provided via PictureReady.
+      NEEDS_ALL_PICTURE_BUFFERS_TO_DECODE = 1 << 0,
+    };
+
+    SupportedProfiles supported_profiles;
+    uint32 flags;

[dcheng, 2015/12/10 07:09:48]

Nit: uint32_t (uint32 is going away)

[liberato (no reviews please), 2015/12/10 15:56:06]

Done, and in gpu_info.h

+  };
+
   // Enumeration of potential errors generated by the API.
   // Note: Keep these in sync with PP_VideoDecodeError_Dev. Also do not
   // rearrange, reuse or remove values as they are used for gathering UMA
   // statistics.
   enum Error {
     // An operation was attempted during an incompatible decoder state.
     ILLEGAL_STATE = 1,
     // Invalid argument was passed to an API method.
     INVALID_ARGUMENT,
     // Encoded input is unreadable.
@@ skipping 162 matching lines @@
 // Specialize std::default_delete so that scoped_ptr<VideoDecodeAccelerator>
 // uses "Destroy()" instead of trying to use the destructor.
 template <>
 struct MEDIA_EXPORT default_delete<media::VideoDecodeAccelerator> {
   void operator()(media::VideoDecodeAccelerator* vda) const;
 };
 
 }  // namespace std
 
 #endif  // MEDIA_VIDEO_VIDEO_DECODE_ACCELERATOR_H_