Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1490313002: Revert of Add all components to "gn check". (Closed)

Created:
5 years ago by dtu
Modified:
5 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@nacl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add all components to "gn check". (patchset #4 id:60001 of https://codereview.chromium.org/1491743002/ ) Reason for revert: Failing Perf (Official) Linux Builder. https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/7266 ERROR at //components/version_info/version_info.cc:12:11: Include not allowed. #include "ui/base/l10n/l10n_util.h" ^----------------------- It is not in any dependency of //components/version_info:version_info The include file is in the target(s): //ui/base:base which should somehow be reachable. GN gen failed: 1 Original issue's description: > Add all components to "gn check". > > All components now pass a "gn check" step. Whitelist with a wildcard. > > R=dpranke@chromium.org > > Committed: https://crrev.com/273b751649ebe3cc3579d9c87166ed3802827fb0 > Cr-Commit-Position: refs/heads/master@{#362652} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d9fd8d3307664ad3f5c5cdc40cd8780c5cb40d2d Cr-Commit-Position: refs/heads/master@{#362725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -27 lines) Patch
M .gn View 1 chunk +152 lines, -1 line 0 comments Download
M components/arc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/exo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/exo/wayland/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/wifi_sync/BUILD.gn View 2 chunks +7 lines, -18 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dtu
Created Revert of Add all components to "gn check".
5 years ago (2015-12-02 16:07:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490313002/1
5 years ago (2015-12-02 16:08:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 16:09:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d9fd8d3307664ad3f5c5cdc40cd8780c5cb40d2d Cr-Commit-Position: refs/heads/master@{#362725}
5 years ago (2015-12-02 16:10:16 UTC) #5
Dirk Pranke
5 years ago (2015-12-02 16:50:35 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698