DescriptionRevert of Add all components to "gn check". (patchset #4 id:60001 of https://codereview.chromium.org/1491743002/ )
Reason for revert:
Failing Perf (Official) Linux Builder.
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/7266
ERROR at //components/version_info/version_info.cc:12:11: Include not allowed.
#include "ui/base/l10n/l10n_util.h"
^-----------------------
It is not in any dependency of
//components/version_info:version_info
The include file is in the target(s):
//ui/base:base
which should somehow be reachable.
GN gen failed: 1
Original issue's description:
> Add all components to "gn check".
>
> All components now pass a "gn check" step. Whitelist with a wildcard.
>
> R=dpranke@chromium.org
>
> Committed: https://crrev.com/273b751649ebe3cc3579d9c87166ed3802827fb0
> Cr-Commit-Position: refs/heads/master@{#362652}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/d9fd8d3307664ad3f5c5cdc40cd8780c5cb40d2d
Cr-Commit-Position: refs/heads/master@{#362725}
Patch Set 1 #
Messages
Total messages: 6 (1 generated)
|