[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

Adds implementation and tests for CreateMappedArguments and
CreateUnmappedArguments to bytecode graph builder.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/5dd3122c634bed495222ebac49f4f935e5d408ad
Cr-Commit-Position: refs/heads/master@{#33004}

[mythria, 2015-12-02 16:05:37]

mythria@chromium.org changed reviewers:
+ mstarzinger@google.com, oth@chromium.org

[mythria, 2015-12-02 16:05:37]

Could you please review my changes.

Thanks,
Mythri

[oth, 2015-12-02 16:21:20]

lgtm, thanks.

[mythria, 2015-12-02 16:22:13]

Description was changed from

==========
[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

Adds implementation and tests for CreateMappedArguments and
CreateUnmappedArguments to bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

Adds implementation and tests for CreateMappedArguments and
CreateUnmappedArguments to bytecode graph builder.

BUG=v8:4280
LOG=N
==========

[mythria, 2015-12-02 16:22:13]

mythria@chromium.org changed reviewers:
+ mstarzinger@chromium.org
- mstarzinger@google.com

[mythria, 2015-12-02 16:23:47]

Hi Michi, 
 I am sorry I added your google Id in my earlier request. Adding the correct one
now. Could you please review my changes.

Thanks,
Mythri

[Michael Starzinger, 2015-12-02 16:34:20]

LGTM.

[mythria, 2015-12-03 12:09:29]

After offline discussion with Michi and orion, we decided not to land this cl
now. We will re-visit this cl when we have deopt support in the interpreter.

This is the summary of discussion:
CreateArguments Runtime calls requires deopt information which is not available
for now. The non-generic version of these calls
(Runtime_NewSloppyArguments/Runtime_NewStrictArguments) do not require deopt
information. However, they work only when there is no inlining. Also,
Runtime_NewSloppyArguments requires deopt information in debug mode to check if
everything is Ok. Hence it is safer not to use the non-generic versions.

[mythria, 2015-12-08 14:55:21]

mythria@chromium.org changed reviewers:
+ rmcilroy@chromium.org
- mstarzinger@chromium.org, oth@chromium.org

[mythria, 2015-12-08 14:55:22]

+Ross

[rmcilroy, 2015-12-19 10:28:33]

Deopt date is now generated for these functions, so you should be able to land
this now. You should also be able to replace retbrow with throw in the graph
builder.

[mythria, 2015-12-21 17:44:38]

mythria@chromium.org changed reviewers:
+ oth@chromium.org
- rmcilroy@chromium.org

[mythria, 2015-12-21 17:44:39]

I updated createArguments with the new FrameStates. Please take a look.

Thanks,
Mythri

[mythria, 2015-12-21 17:46:10]

adding cc to Ross.

[oth, 2015-12-22 08:56:03]

On 2015/12/21 17:46:10, mythria wrote:
> adding cc to Ross.

Frame state looks good here. ++lgtm

[mythria, 2015-12-22 09:23:41]

The CQ bit was checked by mythria@chromium.org

[mythria, 2015-12-22 09:23:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1490283003/#ps60001
(title: "Adds frame state to createArguments node.")

[commit-bot: I haz the power, 2015-12-22 09:23:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1490283003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1490283003/60001

[commit-bot: I haz the power, 2015-12-22 09:25:01]

Description was changed from

==========
[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

Adds implementation and tests for CreateMappedArguments and
CreateUnmappedArguments to bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

Adds implementation and tests for CreateMappedArguments and
CreateUnmappedArguments to bytecode graph builder.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2015-12-22 09:25:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-22 09:25:32]

Description was changed from

==========
[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

Adds implementation and tests for CreateMappedArguments and
CreateUnmappedArguments to bytecode graph builder.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Adds support for CreateArguments to BytecodeGraphBuilder.

Adds implementation and tests for CreateMappedArguments and
CreateUnmappedArguments to bytecode graph builder.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/5dd3122c634bed495222ebac49f4f935e5d408ad
Cr-Commit-Position: refs/heads/master@{#33004}
==========

[commit-bot: I haz the power, 2015-12-22 09:25:32]

Patchset 4 (id:??) landed as
https://crrev.com/5dd3122c634bed495222ebac49f4f935e5d408ad
Cr-Commit-Position: refs/heads/master@{#33004}