Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: net/http/http_network_session.h

Issue 149027: Limit total number of sockets in the system.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: reorder Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.h
diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h
index 3529bc8127b21657a8611a7681ac4662af1057d2..487ade4211f3dc6da61d2100e48a36cafcb04bbb 100644
--- a/net/http/http_network_session.h
+++ b/net/http/http_network_session.h
@@ -5,7 +5,6 @@
#ifndef NET_HTTP_HTTP_NETWORK_SESSION_H_
#define NET_HTTP_HTTP_NETWORK_SESSION_H_
-#include "base/logging.h"
#include "base/ref_counted.h"
#include "net/base/ssl_client_auth_cache.h"
#include "net/base/ssl_config_service.h"
@@ -22,13 +21,7 @@ class ProxyService;
class HttpNetworkSession : public base::RefCounted<HttpNetworkSession> {
public:
HttpNetworkSession(HostResolver* host_resolver, ProxyService* proxy_service,
- ClientSocketFactory* client_socket_factory)
- : connection_pool_(new TCPClientSocketPool(
- max_sockets_per_group_, host_resolver, client_socket_factory)),
- host_resolver_(host_resolver),
- proxy_service_(proxy_service) {
- DCHECK(proxy_service);
- }
+ ClientSocketFactory* client_socket_factory);
HttpAuthCache* auth_cache() { return &auth_cache_; }
SSLClientAuthCache* ssl_client_auth_cache() {
@@ -46,6 +39,9 @@ class HttpNetworkSession : public base::RefCounted<HttpNetworkSession> {
private:
FRIEND_TEST(HttpNetworkTransactionTest, GroupNameForProxyConnections);
+ // Total limit of sockets. Not a constant to allow experiments.
+ static int max_sockets_;
+
// Default to allow up to 6 connections per host. Experiment and tuning may
// try other values (greater than 0). Too large may cause many problems, such
// as home routers blocking the connections!?!?
« no previous file with comments | « no previous file | net/http/http_network_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698