Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1490243002: [Fetch API] Use FetchFormDataConsumerHandle in Response constructor. (Closed)

Created:
5 years ago by yhirano
Modified:
5 years ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Fetch API] Use FetchFormDataConsumerHandle in Response constructor. Use FetchFormDataConsumerHandle in Response::create to simplify the code. This CL also includes some minor refactoring. - Rename "responseInit" with "init" for the simplicity - Replace 0 with nullptr - Wrap comments in 80 cols BUG=564479 Committed: https://crrev.com/89de43871841f2ac9389722d6efb514b87b56f88 Cr-Commit-Position: refs/heads/master@{#362929}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -82 lines) Patch
M third_party/WebKit/Source/modules/fetch/Response.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 4 chunks +47 lines, -81 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yhirano
5 years ago (2015-12-02 10:39:39 UTC) #5
hiroshige
lgtm.
5 years ago (2015-12-03 06:29:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490243002/20001
5 years ago (2015-12-03 07:21:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 07:28:23 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-03 07:29:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89de43871841f2ac9389722d6efb514b87b56f88
Cr-Commit-Position: refs/heads/master@{#362929}

Powered by Google App Engine
This is Rietveld 408576698