Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1490233009: [heap] Make link from optimized code to inlined code explicit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Allow handle deref. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/objects-visiting.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/objects-visiting-inl.h
diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h
index 0e025b22f2af61dabef81bca9136b518c162fc2d..3d914b863f64147d06d10d99cb587639a01019a9 100644
--- a/src/heap/objects-visiting-inl.h
+++ b/src/heap/objects-visiting-inl.h
@@ -415,13 +415,6 @@ void StaticMarkingVisitor<StaticVisitor>::VisitCode(Map* map,
if (FLAG_age_code && !heap->isolate()->serializer_enabled()) {
code->MakeOlder(heap->mark_compact_collector()->marking_parity());
}
- MarkCompactCollector* collector = heap->mark_compact_collector();
- if (collector->is_code_flushing_enabled()) {
- if (code->kind() == Code::OPTIMIZED_FUNCTION) {
- // Visit all unoptimized code objects to prevent flushing them.
- MarkInlinedFunctionsCode(heap, code);
- }
- }
CodeBodyVisitor::Visit(map, object);
}
@@ -605,25 +598,6 @@ void StaticMarkingVisitor<StaticVisitor>::MarkOptimizedCodeMap(
}
-template <typename StaticVisitor>
-void StaticMarkingVisitor<StaticVisitor>::MarkInlinedFunctionsCode(Heap* heap,
- Code* code) {
- // For optimized functions we should retain both non-optimized version
- // of its code and non-optimized version of all inlined functions.
- // This is required to support bailing out from inlined code.
- if (code->deoptimization_data() != heap->empty_fixed_array()) {
- DeoptimizationInputData* const data =
- DeoptimizationInputData::cast(code->deoptimization_data());
- FixedArray* const literals = data->LiteralArray();
- int const inlined_count = data->InlinedFunctionCount()->value();
- for (int i = 0; i < inlined_count; ++i) {
- StaticVisitor::MarkObject(
- heap, SharedFunctionInfo::cast(literals->get(i))->code());
- }
- }
-}
-
-
inline static bool HasSourceCode(Heap* heap, SharedFunctionInfo* info) {
Object* undefined = heap->undefined_value();
return (info->script() != undefined) &&
« no previous file with comments | « src/heap/objects-visiting.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698