Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1490233009: [heap] Make link from optimized code to inlined code explicit. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Make link from optimized code to inlined code explicit. This makes the strong link from optimized code to code objects for all inlined functions explicit. It adds direct references to code objects into deoptimization data as literals. Note that this is not necessarily the code that will be deoptimized to, because the code on the shared function info might be replaced by other components (e.g. debugger). Those replacement code objects however are all non-flushable, marking explicit strong links for reachability unnecessary. R=hpayer@chromium.org Committed: https://crrev.com/0738f53dd628472056da1d430ec95b5f84a54281 Cr-Commit-Position: refs/heads/master@{#32654}

Patch Set 1 #

Patch Set 2 : Allow handle deref. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -31 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Michael Starzinger
5 years ago (2015-12-04 13:28:22 UTC) #1
Hannes Payer (out of office)
LGTM
5 years ago (2015-12-07 10:34:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490233009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490233009/20001
5 years ago (2015-12-07 12:03:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8603)
5 years ago (2015-12-07 12:07:46 UTC) #7
Benedikt Meurer
On 2015/12/07 12:07:46, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-07 12:23:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490233009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490233009/20001
5 years ago (2015-12-07 12:24:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 12:26:00 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-07 12:26:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0738f53dd628472056da1d430ec95b5f84a54281
Cr-Commit-Position: refs/heads/master@{#32654}

Powered by Google App Engine
This is Rietveld 408576698