Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1490233006: [DownloadNotification Test] Use temporary download directory (Closed)

Created:
5 years ago by yoshiki
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DownloadNotification Test] Use temporary download directory This patch has the tests use a temporary download directory so that the download directory won't be full with downloaded files and the flakiness on trybots should be fixed. And this patch also re-enable the tests except SimultaneousIncognitoAndNormalDownloads, which was flakiness due to downloaded files in the download directory. This fix had been committed once (crrev.com/f01a43dd6f) but reverted (crrev.com/c96cd8bc15) due to SimultaneousIncognitoAndNormalDownloads failure. But this failure is caused by an other reason. I'll fix it and re-enable separately. BUG=560329 TEST=browser_tests pass both on trybots and locally TBR=asanka@chromium.org, tapted@chromium.org Committed: https://crrev.com/6adbf2e61e7a6a3dae0c72d5dcf946a6535c13df Cr-Commit-Position: refs/heads/master@{#362906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -105 lines) Patch
M chrome/browser/download/notification/download_notification_browsertest.cc View 19 chunks +51 lines, -105 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490233006/1
5 years ago (2015-12-03 04:17:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490233006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490233006/1
5 years ago (2015-12-03 04:19:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 04:40:43 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 04:41:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6adbf2e61e7a6a3dae0c72d5dcf946a6535c13df
Cr-Commit-Position: refs/heads/master@{#362906}

Powered by Google App Engine
This is Rietveld 408576698