Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1490233005: net: Fix CertVerifyProcTest.LargeKey for OSX 10.11. (Closed)

Created:
5 years ago by erikchen
Modified:
5 years ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Fix two certificate verification tests for OSX 10.11. Apple's verifier rejects certificates as invalid if the key is too large. The maximum size changed from 4096 to 8192 between OSX 10.10 and OSX 10.11. I bumped the size of the RSA key in large_key.pem to 8200 bits. This fixes the tests CertVerifyProcTest.LargeKey and X509CertificatePublicKeyInfoTest.GetPublicKeyInfo. BUG=564380 Committed: https://crrev.com/fcba78138fa1baa0945e9f5f031798c23d9b8205 Cr-Commit-Position: refs/heads/master@{#362829}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix another test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -101 lines) Patch
M net/cert/x509_certificate_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/data/ssl/certificates/large_key.pem View 1 1 chunk +180 lines, -98 lines 0 comments Download
M net/data/ssl/scripts/generate-test-certs.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490233005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490233005/40001
5 years ago (2015-12-02 21:12:09 UTC) #3
erikchen
davidben: Please review.
5 years ago (2015-12-02 21:13:54 UTC) #6
davidben
lgtm
5 years ago (2015-12-02 21:20:12 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 23:05:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490233005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490233005/40001
5 years ago (2015-12-02 23:57:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-03 00:18:26 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-03 00:19:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fcba78138fa1baa0945e9f5f031798c23d9b8205
Cr-Commit-Position: refs/heads/master@{#362829}

Powered by Google App Engine
This is Rietveld 408576698