Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1490223002: exo: Use aura::Windows instead of views::Views as exo::Surfaces. (Closed)

Created:
5 years ago by reveman
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Use aura::Windows instead of views::Views as exo::Surfaces. aura::Windows are needed for proper event-handling. BUG=549781 TEST=exo_unittest --gtest_filter=*SurfaceTest.* Committed: https://crrev.com/4c94cf960c839af59d4d160f0540051c7d9ef688 Cr-Commit-Position: refs/heads/master@{#362921}

Patch Set 1 #

Patch Set 2 : add key event support #

Patch Set 3 : rebase and update unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -50 lines) Patch
M components/exo/shell_surface.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M components/exo/shell_surface.cc View 1 2 7 chunks +21 lines, -4 lines 0 comments Download
M components/exo/sub_surface_unittest.cc View 1 2 4 chunks +14 lines, -14 lines 0 comments Download
M components/exo/surface.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/exo/surface.cc View 1 8 chunks +66 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490223002/1
5 years ago (2015-12-02 08:32:55 UTC) #2
reveman
5 years ago (2015-12-02 08:33:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 08:52:12 UTC) #6
reveman
5 years ago (2015-12-02 15:55:47 UTC) #8
piman
lgtm
5 years ago (2015-12-03 00:40:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490223002/40001
5 years ago (2015-12-03 06:28:55 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-03 06:49:53 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-03 06:50:42 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c94cf960c839af59d4d160f0540051c7d9ef688
Cr-Commit-Position: refs/heads/master@{#362921}

Powered by Google App Engine
This is Rietveld 408576698