components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java - Issue 1490203003: [Cronet] Set HTTP method before starting a request in CronetHttpURLConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

Issue 1490203003: [Cronet] Set HTTP method before starting a request in CronetHttpURLConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetHttpURLConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

index 41b0fc7b967f41ba0bff8b38e01cb2e2d69946ae..4f63155ba89233b77626048fb6f95366ee1c78c2 100644

--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java

@@ -282,6 +282,9 @@ public class CronetHttpURLConnection extends HttpURLConnection {

if (!getUseCaches()) {

requestBuilder.disableCache();

}

+ // Set HttpMethod.

pauljensen 2015/12/03 02:38:47 nit: HttpMethod->HTTP method

xunjieli 2015/12/03 14:45:18 Done.

+ requestBuilder.setHttpMethod(method);

connected = true;

mRequest = requestBuilder.build();

// Start the request.