[Password Manager] Update Confirmation UI for saved password change for Chrome on Android.

chrome/browser/ui/android/infobars/update_password_infobar.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_ANDROID_INFOBARS_UPDATE_PASSWORD_INFOBAR_H_
+#define CHROME_BROWSER_UI_ANDROID_INFOBARS_UPDATE_PASSWORD_INFOBAR_H_
+
+#include "base/android/scoped_java_ref.h"
+#include "base/macros.h"
+#include "chrome/browser/password_manager/update_password_infobar_delegate.h"

[Peter Kasting, 2016/02/13 01:44:52]

Nit: I think you can forward-declare UpdatePasswordInfoBarDelegate instead of
#including this in this header.

[melandory, 2016/02/22 12:41:09]

Done.

+#include "chrome/browser/ui/android/infobars/confirm_infobar.h"
+
+// The Android infobar that offers the user the ability to update a password
+// for the site.

[Peter Kasting, 2016/02/13 01:44:52]

Nit: How about:

The infobar to be used with UpdatePasswordInfoBarDelegate.

[melandory, 2016/02/22 12:41:09]

Done.

+class UpdatePasswordInfoBar : public ConfirmInfoBar {
+ public:
+  static bool Register(JNIEnv* env);

[Peter Kasting, 2016/02/13 01:44:52]

Nit: Google style guide says static methods go below constructor/destructor.

[melandory, 2016/02/22 12:41:09]

Done.

+
+  explicit UpdatePasswordInfoBar(
+      scoped_ptr<UpdatePasswordInfoBarDelegate> delegate);
+  ~UpdatePasswordInfoBar() override;
+
+  int GetIdOfSelectedUsername();

[Peter Kasting, 2016/02/13 01:44:52]

Nit: const?

[melandory, 2016/02/22 12:41:09]

Done.

+
+ private:
+  // ConfirmInfoBar:
+  base::android::ScopedJavaLocalRef<jobject> CreateRenderInfoBar(
+      JNIEnv* env) override;
+  void OnLinkClicked(JNIEnv* env,
+                     const base::android::JavaParamRef<jobject>& obj) override;
+
+  base::android::ScopedJavaGlobalRef<jobject> java_infobar_;
+
+  DISALLOW_COPY_AND_ASSIGN(UpdatePasswordInfoBar);
+};
+
+#endif  // CHROME_BROWSER_UI_ANDROID_INFOBARS_UPDATE_PASSWORD_INFOBAR_H_