chrome/android/java/strings/android_chrome_strings.grd - Issue 1490193003: [Password Manager] Update Confirmation UI for saved password change for Chrome on Android.

Side by Side Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 1490193003: [Password Manager] Update Confirmation UI for saved password change for Chrome on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/UpdatePasswordInfoBar.java ('k') | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2	2

3 <!-- android_chrome_strings.grd contains strings for Chrome for Android.	3 <!-- android_chrome_strings.grd contains strings for Chrome for Android.

4	4

5 FAQ:	5 FAQ:

6 - How do I add, change, or remove a string?	6 - How do I add, change, or remove a string?

7 Just update this file.	7 Just update this file.

8 - Translations will happen automatically??	8 - Translations will happen automatically??

9 Yes, indeed. Just add your string before the branch point and	9 Yes, indeed. Just add your string before the branch point and

10 make the description good.	10 make the description good.

(...skipping 2316 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2327 </message>	2327 </message>

2328 <message name="IDS_PHYSICAL_WEB_EMPTY_LIST_SCANNING" desc="The message dis played in place of a list of nearby URLs while still scanning for nearby URLs.">	2328 <message name="IDS_PHYSICAL_WEB_EMPTY_LIST_SCANNING" desc="The message dis played in place of a list of nearby URLs while still scanning for nearby URLs.">

2329 Looking for nearby Physical Web pages	2329 Looking for nearby Physical Web pages

2330 </message>	2330 </message>

2331 <message name="IDS_PHYSICAL_WEB_REFRESH" desc="The label for a button that initiates a scan for nearby URLs">	2331 <message name="IDS_PHYSICAL_WEB_REFRESH" desc="The label for a button that initiates a scan for nearby URLs">

2332 Refresh	2332 Refresh

2333 </message>	2333 </message>

2334 <message name="IDS_PHYSICAL_WEB_LAUNCH_BUTTON" desc="The label for a butto n that opens a list of nearby URLs">	2334 <message name="IDS_PHYSICAL_WEB_LAUNCH_BUTTON" desc="The label for a butto n that opens a list of nearby URLs">

2335 See what's nearby	2335 See what's nearby

2336 </message>	2336 </message>

	2337

	2338 <!-- Password Manager strings -->

	2339 <message name="IDS_UPDATE_PASSWORD" desc="The title of the update password infobar.">
	Peter Kasting 2016/02/13 01:44:52 Neither of these strings is a "title", they're mes Neither of these strings is a "title", they're messages shown on the infobar. A better description would be something like "A message shown to users to allow updating a saved password for a site, shown in an infobar that appears after the user uses a different password to sign in to the site." The description for the item below should be similar but distinguish why we need to show the user the relevant username. melandory 2016/02/22 12:41:09 Done. Show quoted text On 2016/02/13 01:44:52, Peter Kasting wrote: > Neither of these strings is a "title", they're messages shown on the infobar. A > better description would be something like "A message shown to users to allow > updating a saved password for a site, shown in an infobar that appears after the > user uses a different password to sign in to the site." > > The description for the item below should be similar but distinguish why we need > to show the user the relevant username. Done.
	2340 Do you want <ph name="PASSWORD_MANAGER_BRAND">^1<ex>Google Chrome</ex></ ph> to update your password for this site?

	2341 </message>

	2342 <message name="IDS_UPDATE_PASSWORD_FOR_ACCOUNT" desc="The title of the upd ate password infobar.">

	2343 Do you want <ph name="PASSWORD_MANAGER_BRAND">^1<ex>Google Chrome</ex></ ph> to update your password of <ph name="USERNAME">^2<ex>don.john.lemon@example. com</ex></ph> for this site?
	Peter Kasting 2016/02/13 01:44:52 This sentence doesn't read very grammatically. Di This sentence doesn't read very grammatically. Did a tech writer write this? I would recommend replacing "your password of" with "the password for". melandory 2016/02/22 12:41:09 No, it wasn't. It was string form mocks. Show quoted text On 2016/02/13 01:44:52, Peter Kasting wrote: > This sentence doesn't read very grammatically. Did a tech writer write this? I > would recommend replacing "your password of" with "the password for". No, it wasn't. It was string form mocks.
	2344 </message>

2337 </messages>	2345 </messages>

2338 </release>	2346 </release>

2339 </grit>	2347 </grit>

OLD	NEW