[Password Manager] Update Confirmation UI for saved password change for Chrome on Android.

chrome/browser/password_manager/update_password_infobar_delegate.h

+// Copyright 2015 The Chromium Authors. All rights reserved.

[vabr (Chromium), 2016/01/13 09:44:46]

2015 -> 2016

[melandory, 2016/01/13 15:11:37]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PASSWORD_MANAGER_UPDATE_PASSWORD_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_PASSWORD_MANAGER_UPDATE_PASSWORD_INFOBAR_DELEGATE_H_
+
+#include <vector>
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/password_manager/password_manager_infobar_delegate.h"
+#include "chrome/browser/ui/passwords/manage_passwords_state.h"
+#include "components/password_manager/core/browser/password_form_manager.h"
+
+namespace content {
+class WebContents;
+}
+
+// If PasswordManager encounters the login which is already known or user fills
+// the password change form, then user is prompted with an infobar asking if
+// already saved credentials should be updated or not.
+// In case several credentials are stored for the web site, user can choose
+// which one should be updated.
+class UpdatePasswordInfoBarDelegate : public PasswordManagerInfoBarDelegate {
+ public:
+  static void Create(
+      content::WebContents* web_contents,
+      scoped_ptr<password_manager::PasswordFormManager> form_to_update);
+
+  ~UpdatePasswordInfoBarDelegate() override;
+
+  base::string16 branding() const { return branding_; }
+
+  bool is_smartlock_branding_enabled() const {
+    return is_smartlock_branding_enabled_;
+  }
+
+  // Returns true if infobar for the multi credentials case should be shown, e.g
+  // user changing a password on a password change form and has several
+  // credentials save for the web site.
+  bool ShowMultipleAccounts() const;
+
+  const std::vector<const autofill::PasswordForm*>& GetCurrentForms() const {
+    return passwords_data_.GetCurrentForms();
+  }
+
+  // Returns the username of the saved credentials in case when there is only
+  // one credential pair stored.
+  base::string16 GetUsernameForOneAccountCase();
+
+  // Updates the form with index |from_index| in case of multiple credentials or

[vabr (Chromium), 2016/01/13 09:44:46]

typo: from_index -> form_index

[melandory, 2016/01/13 15:11:37]

Done.

+  // the only available form otherwise.
+  void UpdatePasswordInternal(unsigned int form_index);

[vabr (Chromium), 2016/01/13 09:44:46]

|form_index| comes from jint, which is signed. The style guide also says: "Do
not use unsigned types to mean "this value should never be < 0". For that, use
assertions or run-time checks (as appropriate)."

Therefore I suggest using just int here, and add the non-negativeness to the
check inside UpdatePasswordInternal.

[melandory, 2016/01/13 15:11:36]

Done.

+
+  // ConfirmInfoBarDelegate:
+  infobars::InfoBarDelegate::InfoBarIdentifier GetIdentifier() const override;
+  base::string16 GetButtonLabel(InfoBarButton button) const override;
+  bool Accept() override;
+  bool Cancel() override;
+
+ private:
+  UpdatePasswordInfoBarDelegate(
+      content::WebContents* web_contents,
+      scoped_ptr<password_manager::PasswordFormManager> form_to_update,
+      bool is_smartlock_branding_enabled);
+
+  ManagePasswordsState passwords_data_;
+  base::string16 branding_;
+  bool is_smartlock_branding_enabled_;
+
+  DISALLOW_COPY_AND_ASSIGN(UpdatePasswordInfoBarDelegate);

[vabr (Chromium), 2016/01/13 09:44:46]

#include "base/macros.h" for this macro.

[melandory, 2016/01/13 15:11:36]

Done.

+};
+
+#endif  // CHROME_BROWSER_PASSWORD_MANAGER_UPDATE_PASSWORD_INFOBAR_DELEGATE_H_