include/v8.h - Issue 1490193002: Add ExternalStringResourceBase::IsCompressible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 1490193002: Add ExternalStringResourceBase::IsCompressible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 7f4ebebcd2cd40ae5252925c55df703813a19d70..4215af821b23943d85dad67a6b52e3d0ce7c0734 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -2192,6 +2192,8 @@ class V8_EXPORT String : public Name {

public:

virtual ~ExternalStringResourceBase() {}

+ virtual bool isCompressible() const { return false; }

Yang 2015/12/17 11:41:53 Naming convention would name this "IsCompressible"

hajimehoshi 2016/01/05 08:07:44 Done.

protected:

ExternalStringResourceBase() {}

« no previous file with comments | « no previous file | src/factory.cc » ('j') | src/factory.cc » ('J')