Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: include/v8.h

Issue 1490193002: Add ExternalStringResourceBase::IsCompressible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/factory.cc » ('j') | src/factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** \mainpage V8 API Reference Guide 5 /** \mainpage V8 API Reference Guide
6 * 6 *
7 * V8 is Google's open source JavaScript engine. 7 * V8 is Google's open source JavaScript engine.
8 * 8 *
9 * This set of documents provides reference material generated from the 9 * This set of documents provides reference material generated from the
10 * V8 header file, include/v8.h. 10 * V8 header file, include/v8.h.
(...skipping 2174 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 2185
2186 /** 2186 /**
2187 * Returns true if the string is both external and one-byte. 2187 * Returns true if the string is both external and one-byte.
2188 */ 2188 */
2189 bool IsExternalOneByte() const; 2189 bool IsExternalOneByte() const;
2190 2190
2191 class V8_EXPORT ExternalStringResourceBase { // NOLINT 2191 class V8_EXPORT ExternalStringResourceBase { // NOLINT
2192 public: 2192 public:
2193 virtual ~ExternalStringResourceBase() {} 2193 virtual ~ExternalStringResourceBase() {}
2194 2194
2195 virtual bool isCompressible() const { return false; }
Yang 2015/12/17 11:41:53 Naming convention would name this "IsCompressible"
hajimehoshi 2016/01/05 08:07:44 Done.
2196
2195 protected: 2197 protected:
2196 ExternalStringResourceBase() {} 2198 ExternalStringResourceBase() {}
2197 2199
2198 /** 2200 /**
2199 * Internally V8 will call this Dispose method when the external string 2201 * Internally V8 will call this Dispose method when the external string
2200 * resource is no longer needed. The default implementation will use the 2202 * resource is no longer needed. The default implementation will use the
2201 * delete operator. This method can be overridden in subclasses to 2203 * delete operator. This method can be overridden in subclasses to
2202 * control how allocated external string resources are disposed. 2204 * control how allocated external string resources are disposed.
2203 */ 2205 */
2204 virtual void Dispose() { delete this; } 2206 virtual void Dispose() { delete this; }
(...skipping 6278 matching lines...) Expand 10 before | Expand all | Expand 10 after
8483 */ 8485 */
8484 8486
8485 8487
8486 } // namespace v8 8488 } // namespace v8
8487 8489
8488 8490
8489 #undef TYPE_CHECK 8491 #undef TYPE_CHECK
8490 8492
8491 8493
8492 #endif // INCLUDE_V8_H_ 8494 #endif // INCLUDE_V8_H_
OLDNEW
« no previous file with comments | « no previous file | src/factory.cc » ('j') | src/factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698