Issue 1490133002: Revert of Roll ANGLE 5ac60fc..aca8604

Issue 1490133002: Revert of Roll ANGLE 5ac60fc..aca8604 (Closed)

Created:
5 years ago by sergeyv

Modified:
5 years ago

Reviewers:
Geoff Lang, Jamie Madill

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Roll ANGLE 5ac60fc..aca8604 (patchset #1 id:1 of https://codereview.chromium.org/1489933002/ ) Reason for revert: Compilation failure at Win x64 GN bot: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj.rsp /c ../../third_party/angle/src/tests/egl_tests/EGLDeviceTest.cpp /Foobj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj /Fdobj/third_party/angle/src/tests/angle_end2end_tests_cc.pdb e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(108) : error C3861: 'eglCreateDeviceANGLE': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(113) : error C3861: 'eglQueryDeviceAttribEXT': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(119) : error C3861: 'eglReleaseDeviceANGLE': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(143) : error C3861: 'eglQueryDeviceAttribEXT': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(162) : error C3861: 'eglCreateDeviceANGLE': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(178) : error C3861: 'eglCreateDeviceANGLE': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(187) : error C3861: 'eglQueryDeviceAttribEXT': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(193) : error C3861: 'eglReleaseDeviceANGLE': identifier not found e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(207) : error C3861: 'eglCreateDeviceANGLE': identifier not found http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8780 Original issue's description: > Roll ANGLE 5ac60fc..aca8604 > > https://chromium.googlesource.com/angle/angle.git/+log/5ac60fc..aca8604 > > TBR=jmadill@chromium.org > > BUG= > > TEST=bots > > Committed: https://crrev.com/cf19fdbc2979c0019fad3c2a33a591ab1790e79d > Cr-Commit-Position: refs/heads/master@{#362524} TBR=jmadill@chromium.org,geofflang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8632fc086941dbb745ac798c645494998077f0ce Cr-Commit-Position: refs/heads/master@{#362583}

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490133002/1

5 years ago (2015-12-02 02:11:02 UTC) #2

commit-bot: I haz the power

Description was changed from ========== Revert of Roll ANGLE 5ac60fc..aca8604 (patchset #1 id:1 of https://codereview.chromium.org/1489933002/ ...

5 years ago (2015-12-02 02:14:58 UTC) #3

Message was sent while issue was closed.

Description was changed from

==========
Revert of Roll ANGLE 5ac60fc..aca8604 (patchset #1 id:1 of
https://codereview.chromium.org/1489933002/ )

Reason for revert:
Compilation failure at Win x64 GN bot: 
ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj.rsp /c
../../third_party/angle/src/tests/egl_tests/EGLDeviceTest.cpp
/Foobj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj
/Fdobj/third_party/angle/src/tests/angle_end2end_tests_cc.pdb

e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(108)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(113)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(119)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(143)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(162)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(178)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(187)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(193)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(207)
: error C3861: 'eglCreateDeviceANGLE': identifier not found


http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8780


Original issue's description:
> Roll ANGLE 5ac60fc..aca8604
> 
> https://chromium.googlesource.com/angle/angle.git/+log/5ac60fc..aca8604
> 
> TBR=jmadill@chromium.org
> 
> BUG=
> 
> TEST=bots
> 
> Committed: https://crrev.com/cf19fdbc2979c0019fad3c2a33a591ab1790e79d
> Cr-Commit-Position: refs/heads/master@{#362524}

TBR=jmadill@chromium.org,geofflang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of Roll ANGLE 5ac60fc..aca8604 (patchset #1 id:1 of
https://codereview.chromium.org/1489933002/ )

Reason for revert:
Compilation failure at Win x64 GN bot: 
ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj.rsp /c
../../third_party/angle/src/tests/egl_tests/EGLDeviceTest.cpp
/Foobj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj
/Fdobj/third_party/angle/src/tests/angle_end2end_tests_cc.pdb

e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(108)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(113)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(119)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(143)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(162)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(178)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(187)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(193)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(207)
: error C3861: 'eglCreateDeviceANGLE': identifier not found


http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8780


Original issue's description:
> Roll ANGLE 5ac60fc..aca8604
> 
> https://chromium.googlesource.com/angle/angle.git/+log/5ac60fc..aca8604
> 
> TBR=jmadill@chromium.org
> 
> BUG=
> 
> TEST=bots
> 
> Committed: https://crrev.com/cf19fdbc2979c0019fad3c2a33a591ab1790e79d
> Cr-Commit-Position: refs/heads/master@{#362524}

TBR=jmadill@chromium.org,geofflang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

commit-bot: I haz the power

Description was changed from ========== Revert of Roll ANGLE 5ac60fc..aca8604 (patchset #1 id:1 of https://codereview.chromium.org/1489933002/ ...

5 years ago (2015-12-02 02:16:22 UTC) #5

Message was sent while issue was closed.

Description was changed from

==========
Revert of Roll ANGLE 5ac60fc..aca8604 (patchset #1 id:1 of
https://codereview.chromium.org/1489933002/ )

Reason for revert:
Compilation failure at Win x64 GN bot: 
ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj.rsp /c
../../third_party/angle/src/tests/egl_tests/EGLDeviceTest.cpp
/Foobj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj
/Fdobj/third_party/angle/src/tests/angle_end2end_tests_cc.pdb

e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(108)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(113)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(119)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(143)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(162)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(178)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(187)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(193)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(207)
: error C3861: 'eglCreateDeviceANGLE': identifier not found


http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8780


Original issue's description:
> Roll ANGLE 5ac60fc..aca8604
> 
> https://chromium.googlesource.com/angle/angle.git/+log/5ac60fc..aca8604
> 
> TBR=jmadill@chromium.org
> 
> BUG=
> 
> TEST=bots
> 
> Committed: https://crrev.com/cf19fdbc2979c0019fad3c2a33a591ab1790e79d
> Cr-Commit-Position: refs/heads/master@{#362524}

TBR=jmadill@chromium.org,geofflang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of Roll ANGLE 5ac60fc..aca8604 (patchset #1 id:1 of
https://codereview.chromium.org/1489933002/ )

Reason for revert:
Compilation failure at Win x64 GN bot:
ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj.rsp /c
../../third_party/angle/src/tests/egl_tests/EGLDeviceTest.cpp
/Foobj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj
/Fdobj/third_party/angle/src/tests/angle_end2end_tests_cc.pdb

e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(108)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(113)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(119)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(143)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(162)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(178)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(187)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(193)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(207)
: error C3861: 'eglCreateDeviceANGLE': identifier not found

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8780

Original issue's description:
> Roll ANGLE 5ac60fc..aca8604
>
> https://chromium.googlesource.com/angle/angle.git/+log/5ac60fc..aca8604
>
> TBR=jmadill@chromium.org
>
> BUG=
>
> TEST=bots
>
> Committed: https://crrev.com/cf19fdbc2979c0019fad3c2a33a591ab1790e79d
> Cr-Commit-Position: refs/heads/master@{#362524}

TBR=jmadill@chromium.org,geofflang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Committed: https://crrev.com/8632fc086941dbb745ac798c645494998077f0ce
Cr-Commit-Position: refs/heads/master@{#362583}
==========

commit-bot: I haz the power

5 years ago (2015-12-02 02:16:22 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8632fc086941dbb745ac798c645494998077f0ce
Cr-Commit-Position: refs/heads/master@{#362583}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages